Do not apply skip-unless-changed for cron triggers.

Author: afranchuk

src/taskgraph/optimize/strategies.py

@@ -80,8 +80,8 @@ def check(self, files_changed, patterns):
         return False
 
     def should_remove_task(self, task, params, file_patterns):
-        # pushlog_id == -1 - this is the case when run from a cron.yml job or on a git repository
-        if params.get("repository_type") == "hg" and params.get("pushlog_id") == -1:
+        # skip-unless-changed should not apply to cron tasks (there will never be file changes)
+        if params.get("tasks_for") == "cron":
             return False
 
         changed = self.check(params["files_changed"], file_patterns)

test/test_optimize_strategies.py

@@ -135,7 +135,7 @@ def test_index_search(caplog, responses, params, state, expires, expected, logs)
             {"files_changed": ["bar.txt"]}, ["foo.txt"], True, id="files don't match"
         ),
         pytest.param(
-            {"repository_type": "hg", "pushlog_id": -1, "files_changed": ["bar.txt"]},
+            {"tasks_for": "cron", "files_changed": ["bar.txt"]},
             ["foo.txt"],
             False,
             id="cron task",