Commit dccf18f
committed
test: move basic mesh test under './setup.py test'
In short: this commit moves the basic MeshConnection test cases to the
`./setup.py test` test suites (which are located in the unit/ now) and
removes the test-run submodule, which is not needed anymore.
A bit background: we have a testing framework called test-run, whose
primary goal is to give ability to manage tarantool instances from a
test. Historically tarantool-python does not use test-run for testing
(it uses several simple python helpers instead), but a test-run based
test was added in the scope of #106. The idea was to reuse test-run code
more and eventually port other tests to test-run.
The objective reality reveals several problems in the idea, which looked
nice in theory.
The main problem is the cyclic dependency between test-run and
tarantool-python submodules. It consumes an extra time at recursive git
clone and places old submodule revisions in a deeply nested level. The
latter may confuse linter tools, which search for files recursively (see
[1]).
Other problems look solvable, but I'll list them, because they give
considerable weight in my impression that we should get rid of the
test-run submodule within this repository:
1. test-run based tests were not run in CI and may break silently so
(it already occurs once).
2. The first bullet looks easy to fix, but it is unclear whether it is
right to depend on a submodule in the `./setup.py test` testing or we
should keep only built-in and packaged testing tools in the
dependencies.
3. Porting tests to test-run may require extra effort and nobody was
eager to pay time for that.
4. Existing tooling for managing tarantool instances is enough for
testing of the connector and, at the same time, it is quite simple.
So if we'll meet a problem, it is easier to fix.
5. test-run supports only Python 2 at the moment (however it'll be fixed
soon, see [2]).
To sum up, the experiment with the test-run submodule looks unsuccessful
and I think we should stop it for now. If we'll decide to try again, we
should consider all described problems and implement everything in a way
that does not hurt us.
[1]: tarantool/test-run#266 (comment)
[2]: tarantool/test-run#20
Fixes #1111 parent fb23322 commit dccf18f
File tree
13 files changed
+36
-146
lines changed- test
- cluster-py
- unit/suites
13 files changed
+36
-146
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
0 commit comments