chore: pytestify favorites (#1674)

* fix: black ci errors

* chore: pytestify favorites

---------

Co-authored-by: Jordan Woods <13803242+jorwoods@users.noreply.github.com>

Author: jorwoods

pyproject.toml

@@ -32,20 +32,8 @@ classifiers = [
 repository = "https://github.com/tableau/server-client-python"
 
 [project.optional-dependencies]
-test = ["black==24.10", "build", "mypy==1.4", "pytest>=7.0", "pytest-cov", "pytest-subtests",
-    "pytest-xdist", "requests-mock>=1.0,<2.0", "types-requests>=2.32.4.20250913"]
-
-[tool.setuptools.package-data]
-# Only include data for tableauserverclient, not for samples, test, docs
-tableauserverclient = ["*"]
-
-[tool.setuptools.packages.find]
-where = ["."]
-include = ["tableauserverclient*"]
-
-[tool.setuptools.dynamic]
-version = {attr = "versioneer.get_version"}
-
+test = ["black==24.8", "build", "mypy==1.4", "pytest>=7.0", "pytest-cov", "pytest-subtests",
+    "requests-mock>=1.0,<2.0", "types-requests>=2.32.4.20250913"]
 [tool.black]
 line-length = 120
 target-version = ['py39', 'py310', 'py311', 'py312', 'py313']

test/test_datasource.py

@@ -895,7 +895,8 @@ def test_publish_description(server: TSC.Server) -> None:
     ds_elem = body.find(".//datasource")
     assert ds_elem is not None
     assert ds_elem.attrib["description"] == "Sample description"
-    
+
+
 def test_get_datasource_no_owner(server: TSC.Server) -> None:
     with requests_mock.mock() as m:
         m.get(server.datasources.baseurl, text=GET_NO_OWNER.read_text())

test/test_favorites.py

@@ -5,7 +5,6 @@
 
 import tableauserverclient as TSC
 from tableauserverclient.datetime_helpers import parse_datetime
-from ._utils import read_xml_asset
 
 TEST_ASSET_DIR = Path(__file__).parent / "assets"
 
@@ -45,25 +44,12 @@ def test_get(server: TSC.Server, user: TSC.UserItem) -> None:
     assert len(user.favorites["projects"]) == 1
     assert len(user.favorites["datasources"]) == 1
 
-        collection = self.user.favorites["collections"][0]
-
-        assert collection.id == "8c57cb8a-d65f-4a32-813e-5a3f86e8f94e"
-        assert collection.name == "sample collection"
-        assert collection.description == "description for sample collection"
-        assert collection.total_item_count == 3
-        assert collection.permissioned_item_count == 2
-        assert collection.visibility == "Private"
-        assert collection.created_at == parse_datetime("2016-08-11T21:22:40Z")
-        assert collection.updated_at == parse_datetime("2016-08-11T21:34:17Z")
-
-    def test_add_favorite_workbook(self) -> None:
-        response_xml = read_xml_asset(ADD_FAVORITE_WORKBOOK_XML)
-        workbook = TSC.WorkbookItem("")
-        workbook._id = "6d13b0ca-043d-4d42-8c9d-3f3313ea3a00"
-        workbook.name = "Superstore"
-        with requests_mock.mock() as m:
-            m.put(f"{self.baseurl}/{self.user.id}", text=response_xml)
-            self.server.favorites.add_favorite_workbook(self.user, workbook)
+    workbook = user.favorites["workbooks"][0]
+    print("favorited: ")
+    print(workbook)
+    view = user.favorites["views"][0]
+    datasource = user.favorites["datasources"][0]
+    project = user.favorites["projects"][0]
 
     assert workbook.id == "6d13b0ca-043d-4d42-8c9d-3f3313ea3a00"
     assert view.id == "d79634e1-6063-4ec9-95ff-50acbf609ff5"