Skip to content

Commit 2db07a9

Browse files
vchavatapallijacalata
authored andcommitted
Fixed issues
1 parent 46f363f commit 2db07a9

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

tableauserverclient/server/endpoint/datasources_endpoint.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ def update_connections(
383383
username: Optional[str] = None,
384384
password: Optional[str] = None,
385385
embed_password: Optional[bool] = None,
386-
) -> Iterable[str]:
386+
) -> list[ConnectionItem]:
387387
"""
388388
Bulk updates one or more datasource connections by LUID.
389389
@@ -423,8 +423,8 @@ def update_connections(
423423
embed_password=embed_password,
424424
)
425425
server_response = self.put_request(url, request_body)
426-
connection_items = list(ConnectionItem.from_response(server_response.content, self.parent_srv.namespace))
427-
updated_ids = [conn.id for conn in connection_items]
426+
connection_items = ConnectionItem.from_response(server_response.content, self.parent_srv.namespace)
427+
updated_ids: list[str] = [conn.id for conn in connection_items]
428428

429429
logger.info(f"Updated connections for datasource {datasource_item.id}: {', '.join(updated_ids)}")
430430
return connection_items

tableauserverclient/server/endpoint/workbooks_endpoint.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ def update_connections(
338338
username: Optional[str] = None,
339339
password: Optional[str] = None,
340340
embed_password: Optional[bool] = None,
341-
) -> Iterable[str]:
341+
) -> list[ConnectionItem]:
342342
"""
343343
Bulk updates one or more workbook connections by LUID, including authenticationType, username, password, and embedPassword.
344344
@@ -380,8 +380,8 @@ def update_connections(
380380

381381
# Send request
382382
server_response = self.put_request(url, request_body)
383-
connection_items = list(ConnectionItem.from_response(server_response.content, self.parent_srv.namespace))
384-
updated_ids = [conn.id for conn in connection_items]
383+
connection_items = ConnectionItem.from_response(server_response.content, self.parent_srv.namespace)
384+
updated_ids: list[str] = [conn.id for conn in connection_items]
385385

386386
logger.info(f"Updated connections for workbook {workbook_item.id}: {', '.join(updated_ids)}")
387387
return connection_items

0 commit comments

Comments
 (0)