[Workflow] "clear()" instead of "reset()"

Author: nicolas-grekas

CHANGELOG.md

@@ -4,8 +4,9 @@ CHANGELOG
 4.1.0
 -----
 
- * Deprecate the usage of `add(Workflow $workflow, $supportStrategy)` in `Workflow/Registry`, use `addWorkflow(WorkflowInterface, $supportStrategy)` instead.
- * Deprecate the usage of `SupportStrategyInterface`, use `WorkflowSupportStrategyInterface` instead.
+ * Deprecated the `DefinitionBuilder::reset()` method, use the `clear()` one instead.
+ * Deprecated the usage of `add(Workflow $workflow, $supportStrategy)` in `Workflow/Registry`, use `addWorkflow(WorkflowInterface, $supportStrategy)` instead.
+ * Deprecated the usage of `SupportStrategyInterface`, use `WorkflowSupportStrategyInterface` instead.
  * The `Workflow` class now implements `WorkflowInterface`.
  * Deprecated the class `ClassInstanceSupportStrategy` in favor of the class `InstanceOfSupportStrategy`.
  * Added TransitionBlockers as a way to pass around reasons why exactly

DefinitionBuilder.php

@@ -47,7 +47,7 @@ public function build()
      *
      * @return $this
      */
-    public function reset()
+    public function clear()
     {
         $this->places = array();
         $this->transitions = array();
@@ -121,4 +121,16 @@ public function addTransition(Transition $transition)
 
         return $this;
     }
+
+    /**
+     * @deprecated since Symfony 4.1, use the clear() method instead.
+     *
+     * @return $this
+     */
+    public function reset()
+    {
+        @trigger_error(sprintf('The "%s" method is deprecated since Symfony 4.1, use the "clear()" method instead.', __METHOD__), E_USER_DEPRECATED);
+
+        return $this->clear();
+    }
 }

Event/GuardEvent.php

@@ -42,7 +42,7 @@ public function isBlocked()
     public function setBlocked($blocked)
     {
         if (!$blocked) {
-            $this->transitionBlockerList->reset();
+            $this->transitionBlockerList->clear();
 
             return;
         }

TransitionBlockerList.php

@@ -37,7 +37,7 @@ public function add(TransitionBlocker $blocker): void
         $this->blockers[] = $blocker;
     }
 
-    public function reset(): void
+    public function clear(): void
     {
         $this->blockers = array();
     }