feature #29145 [Workflow] Trigger entered event for subject entering in the Workflow for the first time (lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Workflow] Trigger `entered` event for subject entering in the Workflow for the first time

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28319
| License       | MIT
| Doc PR        |

Commits
-------

388840fd99 [Workflow] Trigger `entered` event for subject entering in the Workflow for the first time

Author: nicolas-grekas

CHANGELOG.md

@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+4.3.0
+-----
+
+ * Trigger `entered` event for subject entering in the Workflow for the first time
+
 4.1.0
 -----
 

Event/Event.php

@@ -35,7 +35,7 @@ class Event extends BaseEvent
      * @param Transition        $transition
      * @param WorkflowInterface $workflow
      */
-    public function __construct($subject, Marking $marking, Transition $transition, $workflow = null)
+    public function __construct($subject, Marking $marking, Transition $transition = null, $workflow = null)
     {
         $this->subject = $subject;
         $this->marking = $marking;

Tests/WorkflowTest.php

@@ -399,6 +399,8 @@ public function testApplyWithEventDispatcher()
         $workflow = new Workflow($definition, new MultipleStateMarkingStore(), $eventDispatcher, 'workflow_name');
 
         $eventNameExpected = array(
+            'workflow.entered',
+            'workflow.workflow_name.entered',
             'workflow.guard',
             'workflow.workflow_name.guard',
             'workflow.workflow_name.guard.t1',

Workflow.php

@@ -61,6 +61,8 @@ public function getMarking($subject)
 
             // update the subject with the new marking
             $this->markingStore->setMarking($subject, $marking);
+
+            $this->entered($subject, null, $marking);
         }
 
         // check that the subject has a known place
@@ -331,7 +333,7 @@ private function enter($subject, Transition $transition, Marking $marking): void
         }
     }
 
-    private function entered($subject, Transition $transition, Marking $marking): void
+    private function entered($subject, Transition $transition = null, Marking $marking): void
     {
         if (null === $this->dispatcher) {
             return;
@@ -342,8 +344,10 @@ private function entered($subject, Transition $transition, Marking $marking): vo
         $this->dispatcher->dispatch('workflow.entered', $event);
         $this->dispatcher->dispatch(sprintf('workflow.%s.entered', $this->name), $event);
 
-        foreach ($transition->getTos() as $place) {
-            $this->dispatcher->dispatch(sprintf('workflow.%s.entered.%s', $this->name, $place), $event);
+        if ($transition) {
+            foreach ($transition->getTos() as $place) {
+                $this->dispatcher->dispatch(sprintf('workflow.%s.entered.%s', $this->name, $place), $event);
+            }
         }
     }