Merge branch '4.2'

* 4.2:
  Explicitly list _field-name_entry_parts
  Improve add to collection JS exemple
  Update the email address related to the Code of Conduct
  feat(encore): ide integration
  Update testing.rst

Author: javiereguiluz

contributing/code_of_conduct/care_team.rst

@@ -19,7 +19,7 @@ Members
 
 Here are all the members of the Code of Conduct CARE team (in alphabetic order).
 You can contact any of them directly using the contact details below or you can
-also contact all of them at once by emailing **coc@symfony.com**:
+also contact all of them at once by emailing **care@symfony.com**:
 
 * **Emilie Lorenzo**
 

email/testing.rst

@@ -22,7 +22,7 @@ Start with a simple controller action that sends an email::
 
         $mailer->send($message);
 
-        return $this->render(...);
+        // ...
     }
 
 In your functional test, use the ``swiftmailer`` collector on the profiler

form/form_themes.rst

@@ -309,7 +309,8 @@ Fragment Naming for Collections
 When using a :doc:`collection of forms </form/form_collections>`, the fragment
 of each collection item follows the pattern ``_field-name_entry_part``. For
 example, if your form field is named ``tasks``, the fragment for each task will
-be named ``_tasks_entry`` (``_tasks_entry_label``, ``_tasks_entry_label``, etc.)
+be named ``_tasks_entry`` (``_tasks_entry_row``, ``_tasks_entry_label``,
+``_tasks_entry_widget``, ``_tasks_entry_error``)
 
 Template Fragment Inheritance
 .............................

frontend/encore/faq.rst

@@ -137,3 +137,34 @@ Babel. But, you can change that via the ``configureBabel()`` method. See
 :doc:`/frontend/encore/babel` for details.
 
 .. _`rsync`: https://rsync.samba.org/
+
+How Do I Integrate my Encore Configuration with my IDE?
+-------------------------------------------------------
+
+`Webpack integration in PhpStorm`_ and other IDEs makes your development more
+productive (for example by resolving aliases). However, you may face this error:
+
+.. code-block:: text
+
+    Encore.setOutputPath() cannot be called yet because the runtime environment
+    doesn't appear to be configured. Make sure you're using the encore executable
+    or call Encore.configureRuntimeEnvironment() first if you're purposely not
+    calling Encore directly.
+
+It fails because the Encore Runtime Environment is only configured when you are
+running it (e.g. when executing ``yarn encore dev``). Fix this issue calling to
+``Encore.isRuntimeEnvironmentConfigured()`` and
+``Encore.configureRuntimeEnvironment()`` methods:
+
+.. code-block:: javascript
+
+    // webpack.config.js
+    const Encore = require('@symfony/webpack-encore')
+
+    if (!Encore.isRuntimeEnvironmentConfigured()) {
+        Encore.configureRuntimeEnvironment(process.env.NODE_ENV || 'dev');
+    }
+
+    // ... the rest of the Encore configuration
+
+.. _`Webpack integration in PhpStorm`: https://www.jetbrains.com/help/phpstorm/using-webpack.html

reference/forms/types/collection.rst

@@ -149,7 +149,7 @@ you need is this JavaScript code:
     // add-collection-widget.js
     jQuery(document).ready(function () {
         jQuery('.add-another-collection-widget').click(function (e) {
-            var list = jQuery(jQuery(this).attr('data-list'));
+            var list = jQuery(jQuery(this).attr('data-list-selector'));
             // Try to find the counter of the list or use the length of the list
             var counter = list.data('widget-counter') | list.children().length;
 
@@ -180,7 +180,8 @@ And update the template as follows:
         {# store the prototype on the data-prototype attribute #}
         <ul id="email-fields-list"
             data-prototype="{{ form_widget(form.emails.vars.prototype)|e }}"
-            data-widget-tags="{{ '<li></li>'|e }}">
+            data-widget-tags="{{ '<li></li>'|e }}"
+            data-widget-counter="{{ form.children|length }}">
         {% for emailField in form.emails %}
             <li>
                 {{ form_errors(emailField) }}
@@ -191,7 +192,7 @@ And update the template as follows:
 
         <button type="button"
             class="add-another-collection-widget"
-            data-list="#email-fields-list">Add another email</button>
+            data-list-selector="#email-fields-list">Add another email</button>
 
         {# ... #}
     {{ form_end(form) }}