chore(review): apply coderabbit fixes

Author: rhahao

src/v3/middleware/app_version_checker.ts

@@ -1,7 +1,7 @@
 import { NextFunction, Request, Response } from 'express';
 import { check, validationResult } from 'express-validator';
-import { API_VAR } from '../../index.js';
 import { formatError } from '../utils/format_log.js';
+import { isValidClientVersion } from '../utils/app.js';
 
 export const appVersionChecker = () => {
 	return async (req: Request, res: Response, next: NextFunction) => {
@@ -30,20 +30,16 @@ export const appVersionChecker = () => {
 				return;
 			}
 
-			const appMinimum = API_VAR.MINIMUM_APP_VERSION;
+			const validVersion = isValidClientVersion(appVersion);
 
-			const majorOK = +appVersion.split('.')[0] > +appMinimum.split('.')[0];
-			const minorOK = +appVersion.split('.')[1] > +appMinimum.split('.')[1];
-			const patchOK = +appVersion.split('.')[2] > +appMinimum.split('.')[2];
-
-			if (appMinimum === appVersion || majorOK || (!majorOK && minorOK) || (!minorOK && patchOK)) {
-				next();
+			if (!validVersion) {
+				res.locals.type = 'warn';
+				res.locals.message = `client version outdated`;
+				res.status(400).json({ message: 'CLIENT_VERSION_OUTDATED' });
 				return;
 			}
 
-			res.locals.type = 'warn';
-			res.locals.message = `client version outdated`;
-			res.status(400).json({ message: 'CLIENT_VERSION_OUTDATED' });
+			next();
 		} catch (err) {
 			next(err);
 		}

src/v3/routes/admin.ts

@@ -50,7 +50,7 @@ router.get('/logout', logoutAdmin);
 router.get('/client-version', getClientVersion);
 
 // get minimum client
-router.post('/client-version', updateClientVersion);
+router.post('/client-version', body('version').isString().notEmpty(), updateClientVersion);
 
 // create new congregation
 router.post(

src/v3/utils/app.ts

@@ -1,4 +1,5 @@
 import { CookieOptions, Request } from 'express';
+import { API_VAR } from '../../index.js';
 
 const isLocalRequest = (req: Request) => {
 	const host = req.get('host');
@@ -16,3 +17,19 @@ export const cookieOptions = (req: Request): CookieOptions => {
 		maxAge: 400 * 24 * 60 * 60 * 1000,
 	};
 };
+
+export const isValidClientVersion = (version: string) => {
+	const parts1 = version.split('.').map(Number);
+	const parts2 = API_VAR.MINIMUM_APP_VERSION.split('.').map(Number);
+
+	const maxLength = Math.max(parts1.length, parts2.length);
+	for (let i = 0; i < maxLength; i++) {
+		const num1 = parts1[i] ?? 0;
+		const num2 = parts2[i] ?? 0;
+
+		if (num1 > num2) return true;
+		if (num1 < num2) return false;
+	}
+
+	return true;
+};