Skip to content

Commit ded98aa

Browse files
committed
chore: create new JSObject instead of using globals in tracing unittest
1 parent 1eef351 commit ded98aa

File tree

1 file changed

+14
-11
lines changed

1 file changed

+14
-11
lines changed

Tests/JavaScriptKitTests/JSTracingTests.swift

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -40,20 +40,23 @@ final class JSTracingTests: XCTestCase {
4040
}
4141
defer { remove() }
4242

43-
let obj = JSObject.global.globalObject1
43+
let obj = JSObject()
44+
obj.foo = .number(42)
45+
46+
// Reset after setup so we only capture the reads/writes below.
47+
startInfo.removeAll()
48+
ended = 0
4449

4550
// Read a property (triggers propertyGet)
46-
let _: JSValue = obj.prop_1
51+
let _: JSValue = obj.foo
4752

4853
// Write a property (triggers propertySet)
49-
obj.prop_1 = .number(999)
54+
obj.foo = .number(999)
5055

51-
// Filter to only propertyGet/propertySet events (subscript reads for the
52-
// method-call test fixture also fire propertyGet, so be precise).
5356
let propEvents = startInfo.filter {
5457
switch $0 {
55-
case .propertyGet(_, let name) where name == "prop_1": return true
56-
case .propertySet(_, let name, _) where name == "prop_1": return true
58+
case .propertyGet(_, let name) where name == "foo": return true
59+
case .propertySet(_, let name, _) where name == "foo": return true
5760
default: return false
5861
}
5962
}
@@ -64,15 +67,15 @@ final class JSTracingTests: XCTestCase {
6467
XCTFail("Expected propertyGet info")
6568
return
6669
}
67-
XCTAssertEqual(getReceiver.id, obj.object!.id)
68-
XCTAssertEqual(getName, "prop_1")
70+
XCTAssertEqual(getReceiver.id, obj.id)
71+
XCTAssertEqual(getName, "foo")
6972

7073
guard case .propertySet(let setReceiver, let setName, let setValue) = propEvents[1] else {
7174
XCTFail("Expected propertySet info")
7275
return
7376
}
74-
XCTAssertEqual(setReceiver.id, obj.object!.id)
75-
XCTAssertEqual(setName, "prop_1")
77+
XCTAssertEqual(setReceiver.id, obj.id)
78+
XCTAssertEqual(setName, "foo")
7679
XCTAssertEqual(setValue, .number(999))
7780

7881
XCTAssertEqual(ended, startInfo.count)

0 commit comments

Comments
 (0)