Small compile-speed optimization

Author: kateinoigakukun

Plugins/PackageToJS/Sources/PackageToJS.swift

@@ -30,23 +30,6 @@ struct PackageToJS {
     }
 }
 
-func which(_ executable: String) throws -> URL {
-    let pathSeparator: Character
-    #if os(Windows)
-        pathSeparator = ";"
-    #else
-        pathSeparator = ":"
-    #endif
-    let paths = ProcessInfo.processInfo.environment["PATH"]!.split(separator: pathSeparator)
-    for path in paths {
-        let url = URL(fileURLWithPath: String(path)).appendingPathComponent(executable)
-        if FileManager.default.isExecutableFile(atPath: url.path) {
-            return url
-        }
-    }
-    throw PackageToJSError("Executable \(executable) not found in PATH")
-}
-
 struct PackageToJSError: Swift.Error, CustomStringConvertible {
     let description: String
 
@@ -297,3 +280,28 @@ struct PackagingPlanner {
         }
     }
 }
+
+// MARK: - Utilities
+
+func which(_ executable: String) throws -> URL {
+    let pathSeparator: Character
+    #if os(Windows)
+        pathSeparator = ";"
+    #else
+        pathSeparator = ":"
+    #endif
+    let paths = ProcessInfo.processInfo.environment["PATH"]!.split(separator: pathSeparator)
+    for path in paths {
+        let url = URL(fileURLWithPath: String(path)).appendingPathComponent(executable)
+        if FileManager.default.isExecutableFile(atPath: url.path) {
+            return url
+        }
+    }
+    throw PackageToJSError("Executable \(executable) not found in PATH")
+}
+
+func logCommandExecution(_ command: String, _ arguments: [String]) {
+    var fullArguments = [command]
+    fullArguments.append(contentsOf: arguments)
+    print("$ \(fullArguments.map { "\"\($0)\"" }.joined(separator: " "))")
+}

Plugins/PackageToJS/Sources/PackageToJSPlugin.swift

@@ -1,5 +1,12 @@
 #if canImport(PackagePlugin)
-@preconcurrency import Foundation  // For "stderr"
+import struct Foundation.URL
+import struct Foundation.Data
+import class Foundation.Process
+import class Foundation.ProcessInfo
+import class Foundation.FileManager
+import func Foundation.fputs
+import func Foundation.exit
+@preconcurrency import var Foundation.stderr
 import PackagePlugin
 
 /// The main entry point for the PackageToJS plugin.
@@ -209,7 +216,7 @@ struct PackageToJSPlugin: CommandPlugin {
         let node = try which("node")
         let arguments = ["--experimental-wasi-unstable-preview1", testRunner.path] + extraArguments
         print("Running test...")
-        print("$ \(([node.path] + arguments).map { "\"\($0)\"" }.joined(separator: " "))")
+        logCommandExecution(node.path, arguments)
 
         let task = Process()
         task.executableURL = node