NFC: BridgeJS: Simplify liftExpression by using no-arg bridgeJSLiftParameter() for enums and protocols

Author: krodak

Plugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift

@@ -779,30 +779,11 @@ struct StackCodegen {
     func liftExpression(for type: BridgeType) -> ExprSyntax {
         switch type {
         case .string, .int, .uint, .bool, .float, .double,
-            .jsObject(nil), .jsValue, .swiftStruct, .swiftHeapObject:
+            .jsObject(nil), .jsValue, .swiftStruct, .swiftHeapObject, .unsafePointer,
+            .swiftProtocol, .caseEnum, .associatedValueEnum, .rawValueEnum:
             return "\(raw: type.swiftType).bridgeJSLiftParameter()"
         case .jsObject(let className?):
             return "\(raw: className)(unsafelyWrapping: JSObject.bridgeJSLiftParameter())"
-        case .unsafePointer:
-            return "\(raw: type.swiftType).bridgeJSLiftParameter()"
-        case .swiftProtocol(let protocolName):
-            return "Any\(raw: protocolName).bridgeJSLiftParameter(_swift_js_pop_i32())"
-        case .caseEnum:
-            return "\(raw: type.swiftType).bridgeJSLiftParameter(_swift_js_pop_i32())"
-        case .rawValueEnum(_, let rawType):
-            switch rawType {
-            case .string:
-                return
-                    "\(raw: type.swiftType).bridgeJSLiftParameter(_swift_js_pop_i32(), _swift_js_pop_i32())"
-            case .float:
-                return "\(raw: type.swiftType).bridgeJSLiftParameter(_swift_js_pop_f32())"
-            case .double:
-                return "\(raw: type.swiftType).bridgeJSLiftParameter(_swift_js_pop_f64())"
-            case .bool, .int, .int32, .int64, .uint, .uint32, .uint64:
-                return "\(raw: type.swiftType).bridgeJSLiftParameter(_swift_js_pop_i32())"
-            }
-        case .associatedValueEnum:
-            return "\(raw: type.swiftType).bridgeJSLiftParameter(_swift_js_pop_i32())"
         case .nullable(let wrappedType, let kind):
             return liftNullableExpression(wrappedType: wrappedType, kind: kind)
         case .array(let elementType):

Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/EnumAssociatedValue.swift

@@ -260,9 +260,9 @@ extension TypedPayloadResult: _BridgedSwiftAssociatedValueEnum {
     @_spi(BridgeJS) @_transparent public static func bridgeJSStackPopPayload(_ caseId: Int32) -> TypedPayloadResult {
         switch caseId {
         case 0:
-            return .precision(Precision.bridgeJSLiftParameter(_swift_js_pop_f32()))
+            return .precision(Precision.bridgeJSLiftParameter())
         case 1:
-            return .direction(CardinalDirection.bridgeJSLiftParameter(_swift_js_pop_i32()))
+            return .direction(CardinalDirection.bridgeJSLiftParameter())
         case 2:
             return .optPrecision(Optional<Precision>.bridgeJSLiftParameter())
         case 3:
@@ -312,7 +312,7 @@ extension AllTypesResult: _BridgedSwiftAssociatedValueEnum {
         case 2:
             return .jsObjectPayload(JSObject.bridgeJSLiftParameter())
         case 3:
-            return .nestedEnum(APIResult.bridgeJSLiftParameter(_swift_js_pop_i32()))
+            return .nestedEnum(APIResult.bridgeJSLiftParameter())
         case 4:
             return .arrayPayload([Int].bridgeJSLiftParameter())
         case 5:

Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSCodegenTests/SwiftStruct.swift

@@ -223,7 +223,7 @@ fileprivate func _bjs_struct_lift_Session() -> Int32 {
 extension Measurement: _BridgedSwiftStruct {
     @_spi(BridgeJS) @_transparent public static func bridgeJSLiftParameter() -> Measurement {
         let optionalPrecision = Optional<Precision>.bridgeJSLiftParameter()
-        let precision = Precision.bridgeJSLiftParameter(_swift_js_pop_f32())
+        let precision = Precision.bridgeJSLiftParameter()
         let value = Double.bridgeJSLiftParameter()
         return Measurement(value: value, precision: precision, optionalPrecision: optionalPrecision)
     }