Isolated keyword should not be permitted in inheritance clause

AlexsanderDamaceno · AlexsanderDamaceno · commit c327081b4940 · 2025-12-11T23:46:04.000-03:00
diff --git a/lib/Sema/TypeCheckType.cpp b/lib/Sema/TypeCheckType.cpp
@@ -5393,8 +5393,8 @@ TypeResolver::resolveIsolatedTypeRepr(IsolatedTypeRepr *repr,
                                       TypeResolutionOptions options) {
   // isolated is only value for non-EnumCaseDecl parameters.
   if ((!options.is(TypeResolverContext::FunctionInput) ||
-       options.hasBase(TypeResolverContext::EnumElementDecl)) &&
-      !options.is(TypeResolverContext::Inherited)) {
+       (options.hasBase(TypeResolverContext::EnumElementDecl) &&
+      !options.is(TypeResolverContext::Inherited)) || options.is(TypeResolverContext::Inherited))) {
     diagnoseInvalid(
         repr, repr->getSpecifierLoc(), diag::attr_only_on_parameters,
         "isolated");
diff --git a/test/Concurrency/isolated_parameters.swift b/test/Concurrency/isolated_parameters.swift
@@ -343,3 +343,8 @@ struct WritableActorKeyPath<Root: Actor, Value>: Sendable {
         nonmutating set { setter(root, newValue) }
     }
 }
+
+protocol P {}
+struct S: isolated P {} // expected-error {{'isolated' may only be used on parameters}}
+
+

Original file line number	Diff line number	Diff line change
`@@ -343,3 +343,8 @@ struct WritableActorKeyPath<Root: Actor, Value>: Sendable {`
`343`	`343`	`nonmutating set { setter(root, newValue) }`
`344`	`344`	`}`
`345`	`345`	`}`
	`346`	`+`
	`347`	`+protocol P {}`
	`348`	`+struct S: isolated P {} // expected-error {{'isolated' may only be used on parameters}}`
	`349`	`+`
	`350`	`+`