Merge pull request #49 from superleap/gils13-mocha-tests

Gils13 mocha tests

Author: TED Vortex (Teodor Eugen Dutulescu)

.bithoundrc

@@ -13,7 +13,12 @@
             "engine": "eslint"
         },
         "wc": {
-            "limit": 1000
+            "limit": 1500
         }
+    },
+    "dependencies": {
+        "mute": [
+            "gulp-spawn-mocha"
+        ]
     }
 }

.eslintignore

@@ -3,3 +3,4 @@ build/
 node_modules/
 lib/
 examples/
+test/

.gitignore

@@ -215,4 +215,5 @@ jsx/
 material-ui/
 svg/
 .publish/
+.nyc_output/
 lib/

.travis.yml

@@ -21,6 +21,7 @@ before_install:
 before_script:
   - npm prune
 after_success:
+  - bash <(curl -s https://codecov.io/bash)
   - npm run release
 branches:
   except:

README.md

@@ -5,7 +5,7 @@
 [![current version](https://img.shields.io/npm/v/github-issues-label-sync.svg?style=flat-square)](https://www.npmjs.com/package/github-asana-tag-sync) [![current version](https://img.shields.io/node/v/github-issues-label-sync.svg?style=flat-square)](https://www.npmjs.com/package/github-asana-tag-sync) 
 [![Dependency Status](https://david-dm.org/superleap/github-issues-label-sync.svg)](https://david-dm.org/superleap/github-issues-label-sync) [![devDependency Status](https://david-dm.org/superleap/github-issues-label-sync/dev-status.svg)](https://david-dm.org/superleap/github-issues-label-sync#info=devDependencies) 
 
-[![bitHound Overall Score](https://www.bithound.io/github/superleap/github-issues-label-sync/badges/score.svg)](https://www.bithound.io/github/superleap/github-issues-label-sync) [![bitHound Dependencies](https://www.bithound.io/github/superleap/github-issues-label-sync/badges/dependencies.svg)](https://www.bithound.io/github/superleap/github-issues-label-sync/master/dependencies/npm) [![bitHound Dev Dependencies](https://www.bithound.io/github/superleap/github-issues-label-sync/badges/devDependencies.svg)](https://www.bithound.io/github/superleap/github-issues-label-sync/master/dependencies/npm) [![bitHound Code](https://www.bithound.io/github/superleap/github-issues-label-sync/badges/code.svg)](https://www.bithound.io/github/superleap/github-issues-label-sync)
+[![codecov](https://codecov.io/gh/superleap/github-issues-label-sync/branch/master/graph/badge.svg)](https://codecov.io/gh/superleap/github-issues-label-sync) [![bitHound Overall Score](https://www.bithound.io/github/superleap/github-issues-label-sync/badges/score.svg)](https://www.bithound.io/github/superleap/github-issues-label-sync) [![bitHound Dependencies](https://www.bithound.io/github/superleap/github-issues-label-sync/badges/dependencies.svg)](https://www.bithound.io/github/superleap/github-issues-label-sync/master/dependencies/npm) [![bitHound Dev Dependencies](https://www.bithound.io/github/superleap/github-issues-label-sync/badges/devDependencies.svg)](https://www.bithound.io/github/superleap/github-issues-label-sync/master/dependencies/npm) [![bitHound Code](https://www.bithound.io/github/superleap/github-issues-label-sync/badges/code.svg)](https://www.bithound.io/github/superleap/github-issues-label-sync)
 
 [![License](http://img.shields.io/:license-BSD2-blue.svg?style=flat-square)](https://opensource.org/licenses/BSD-2-Clause) [![GitHub issues](https://img.shields.io/github/issues/superleap/github-issues-label-sync.svg)](https://github.com/superleap/github-issues-label-sync/issues) [![Join the chat at https://gitter.im/superleap/github-issues-label-sync](https://badges.gitter.im/superleap/github-issues-label-sync.svg)](https://gitter.im/superleap/github-issues-label-sync?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 
@@ -251,6 +251,26 @@ githubIssuesLabelSync.createLabels(labels).then((response) => {
 });
 ```
 
+### Update a label
+
+```
+githubIssuesLabelSync.updateLabel(labels[0]).then((response) => {
+  console.log(response);
+}).catch((error) => {
+  console.log(error.toJSON());
+});
+```
+
+### Update multiple labels
+
+```
+githubIssuesLabelSync.updateLabels(labels).then((response) => {
+  console.log(response);
+}).catch((error) => {
+  console.log(error.toJSON());
+});
+```
+
 ### Delete a label
 
 ```

codecov.yml

@@ -0,0 +1,19 @@
+comment:
+  layout: "header, diff, tree"
+  branches:
+  - master
+  - gils*
+
+coverage:
+  range: "80...100"
+  status:
+    project:
+      default:
+        target: "95%"
+        threshold: "2.5%"
+    patch: true
+    changes: false
+  notify:
+    gitter:
+      default:
+        only_pulls: true

gulpfile.babel.js

@@ -21,6 +21,7 @@ const paths = {
     "manual": "./build/manual",
     "src": "./src/*",
     "srcEsdoc": "./src",
+    "srcTest": "./test/**/*.js",
     "compile": "./lib"
 };
 
@@ -33,7 +34,7 @@ const paths = {
  * @param {String} [opts.stdio=`inherit`] - spawn environment inherits parent
  * @return {Promise<Error>}
  */
-function spawnp(proc, args = [], opts = { "stdio": `inherit` }) {
+function spawnp(proc, args = [], opts = {"stdio": `inherit`}) {
     return new Promise((resolve, reject) => {
         const child = spawn(proc, args, opts);
 
@@ -187,11 +188,22 @@ gulp.task(`setup`, [`clean`], () => {
     });
 });
 
+gulp.task(`test:code`, () => {
+    return gulp.src([paths.srcTest])
+        .pipe(gp.spawnMocha({
+            "env": {
+                "NODE_ENV": 'test'
+            },
+            "R": 'spec',
+            "r": 'babel-register',
+            "istanbul": false
+        }));
+});
+
 
 gulp.task(`test:install`, [`nsp`, `snyk`, `bithound`]);
 gulp.task(`test:publish`, [`package`]);
-gulp.task(`test`, [`lint`]);
 gulp.task(`clean`, [`clean:docs`, `clean:manual`]);
 gulp.task(`postinstall`, [`test:install`]);
 gulp.task(`prepublish`, [`test:publish`]);
-gulp.task(`default`, [`test`]);
+gulp.task(`default`, [`test:code`, `lint`]);

package.json

@@ -6,7 +6,7 @@
     "node": ">=4"
   },
   "scripts": {
-    "test": "gulp",
+    "test": "nyc gulp",
     "prepublish": "gulp prepublish",
     "deploy": "gulp deploy",
     "release": "semantic-release pre && npm publish && semantic-release post"
@@ -39,34 +39,36 @@
     "@semantic-release/last-release-npm": "https://github.com/vrtxf/last-release-npm/tarball/da5a0f2411e2add6f5b0b990b4a12fad3245cfac",
     "babel-core": "^6.11.4",
     "babel-plugin-add-module-exports": "^0.2.1",
+    "babel-plugin-istanbul": "^1.0.3",
     "babel-plugin-transform-es2015-block-scoping": "^6.10.1",
     "babel-preset-es2015": "^6.9.0",
     "babel-register": "^6.11.6",
     "bithound": "1.7.0",
-    "commitizen": "^2.8.2",
+    "chai": "^3.5.0",
+    "chai-as-promised": "^5.3.0",
+    "commitizen": "^2.8.4",
     "cz-conventional-changelog": "^1.1.6",
     "del": "^2.2.1",
     "esdoc": "^0.4.7",
     "esdoc-hacker-vision": "^1.1.0",
     "esdoc-node": "^1.0.0",
-    "eslint": "^3.2.0",
+    "eslint": "^3.2.2",
     "gulp": "^3.9.1",
     "gulp-babel": "^6.1.2",
-    "gulp-codecov": "^2.0.2",
     "gulp-esdoc": "^0.2.0",
     "gulp-eslint": "^3.0.1",
     "gulp-exclude-gitignore": "^1.0.0",
     "gulp-gh-pages": "^0.5.4",
-    "gulp-istanbul": "^1.0.0",
     "gulp-load-plugins": "^1.2.4",
-    "gulp-mocha": "^2.2.0",
     "gulp-nsp": "^2.4.2",
-    "gulp-plumber": "^1.1.0",
+    "gulp-spawn-mocha": "^3.0.0",
     "mkdirp": "^0.5.1",
-    "mocha": "^2.5.3",
+    "mocha": "^3.0.1",
     "nsp": "^2.6.1",
+    "nyc": "^7.1.0",
     "read-package-json": "^2.0.4",
     "semantic-release": "^6.3.0",
+    "sinon": "^1.17.5",
     "snyk": "^1.17.5",
     "standard-changelog": "0.0.1"
   },
@@ -87,6 +89,32 @@
     "plugins": [
       "add-module-exports",
       "transform-es2015-block-scoping"
-    ]
+    ],
+    "env": {
+      "test": {
+        "plugins": [
+          "istanbul"
+        ]
+      }
+    }
+  },
+  "nyc": {
+    "lines": 95,
+    "statements": 95,
+    "functions": 95,
+    "branches": 95,
+    "include": [
+      "src/**/*.js"
+    ],
+    "reporter": [
+      "lcov",
+      "text-summary"
+    ],
+    "require": [
+      "babel-register"
+    ],
+    "sourceMap": false,
+    "instrument": false,
+    "check-coverage": true
   }
 }

src/LabelSync.js

@@ -316,7 +316,7 @@ export default class GithubIssuesLabelSync {
                 let success = true;
 
                 if (error) {
-                    if (error.toJSON().code === 404) {
+                    if (error.code === 404) {
                         label.status = 'not found';
                     } else {
                         success = false;
@@ -379,14 +379,13 @@ export default class GithubIssuesLabelSync {
                 let success = true;
 
                 if (error) {
-                    if (JSON.parse(error.toJSON().message).errors[0].code === 'already_exists') {
+                    if (error.code === 422 && JSON.parse(error.message).errors[0].code === 'already_exists') {
                         label.status = 'duplicate';
                     } else {
                         success = false;
                         reject(error);
                     }
                 } else {
-                    success = true;
                     label.status = 'success';
                 }
 

test/LabelSync/constructorTest.js

@@ -0,0 +1,31 @@
+import chai from 'chai';
+import chaiAsPromised from 'chai-as-promised';
+import sinon from 'sinon';
+import config from './../test-config';
+
+let expect = chai.expect;
+let LabelSync = require('./../../src/LabelSync');
+
+chai.use(chaiAsPromised);
+
+/**
+ * @test {LabelSync}
+ */
+describe('LabelSync#constructor', () => {
+    let LabelSyncTest;
+    let authenticate;
+
+    beforeEach(() => {
+        LabelSyncTest = new LabelSync(undefined, config.user, config.repo, config.token);
+    });
+
+    /**
+     * @test {LabelSync#constructor}
+     */
+    it('should be able to setup the class with default parameters', (done) => {
+        authenticate = sinon.stub(LabelSyncTest, 'authenticate');
+        expect(LabelSyncTest).to.be.an('object');
+        authenticate.restore();
+        done();
+    });
+});