Merge pull request #32 from superleap/gils31-bithound-local-checks

Gils31 bithound local checks

Author: TED Vortex (Teodor Eugen Dutulescu)

.eslintignore

@@ -2,3 +2,4 @@
 build/
 node_modules/
 lib/
+examples/

.eslintrc

@@ -20,12 +20,12 @@
     "accessor-pairs": 2,
     "array-callback-return": 2,
     "block-scoped-var": 2,
-    "complexity": [1, 2],
+    "complexity": [2, {"max": 3}],
     "consistent-return": 2,
     "curly": 2,
     "default-case": 2,
     "dot-location": [2, "property"],
-    "dot-notation": [1, {"allowKeywords": false}],
+    "dot-notation": 2,
     "eqeqeq": [2, "always"],
     "guard-for-in": 2,
     "no-alert": 2,

gulpfile.babel.js

@@ -1,15 +1,17 @@
 import Promise from 'bluebird';
 import childProcess from 'child_process';
 import conventionalChangelog from 'conventional-changelog';
+import del from 'del';
 import fs from 'fs';
 import gulp from 'gulp';
 import gulpLoadPlugins from 'gulp-load-plugins';
+import mkdirp from 'mkdirp';
 import path from 'path';
 import readPackage from 'read-package-json';
 
-let exec = childProcess.exec;
 let pkg = Promise.promisify(readPackage);
 let readFile = Promise.promisify(fs.readFile);
+let spawn = childProcess.spawn;
 let writeFile = Promise.promisify(fs.writeFile);
 
 const gp = gulpLoadPlugins();
@@ -23,29 +25,27 @@ const paths = {
 };
 
 /**
- * Promisified child_process.exec
- * @param cmd
- * @param {Object} [opts={}] See child_process.exec node docs
- * @property {stream.Writable} [opts.stdout=process.stdout] - If defined, child process stdout will be piped to it.
- * @property {stream.Writable} [opts.stderr=process.stderr] - If defined, child process stderr will be piped to it.
- * @returns {Promise<{ stdout: string, stderr: stderr }>}
+ * Promisified child_process.spawn
+ * @async
+ * @param {String} proc - The process we want to spawn
+ * @param {Array} args - The arguments we want to spawn the process with
+ * @param {Object} opts - See child_process.exec node docs
+ * @param {String} [opts.stdio=`inherit`] - spawn environment inherits parent
+ * @return {Promise<Error>}
  */
-function execp(cmd, opts = {}) {
+function spawnp(proc, args = [], opts = { "stdio": `inherit` }) {
     return new Promise((resolve, reject) => {
-        const child = exec(cmd, opts,
-            (err, stdout, stderr) => {
-                return err ? reject(err) : resolve({
-                    "stdout": stdout,
-                    "stderr": stderr
-                });
-            });
+        const child = spawn(proc, args, opts);
+
+        child.on(`error`, (err) => {
+            reject(err);
+        });
 
-        if (opts.stdout) {
-            child.stdout.pipe(opts.stdout);
-        }
-        if (opts.stderr) {
-            child.stderr.pipe(opts.stderr);
-        }
+        child.on(`close`, (code) => {
+            if (code === 0) {
+                resolve();
+            }
+        });
     });
 }
 
@@ -148,15 +148,15 @@ gulp.task(`nsp`, (cb) => {
 });
 
 gulp.task(`snyk`, () => {
-    return execp(`node_modules/.bin/snyk test`);
+    return spawnp(`node_modules/.bin/snyk`, ["test", "--debug"]);
 });
 
 gulp.task(`bithound`, () => {
     return pkg(paths.pkg, console.log, true).then((data) => {
         let pkgName = data.name;
         let pkgUser = data.repository.url.match(/github\.com\/([^\/]+)\//i)[1];
 
-        return execp(`node_modules/.bin/bithound check git@github.com:${pkgUser}/${pkgName}.git`);
+        return spawnp(`node_modules/.bin/bithound`, [`check`, `git@github.com:${pkgUser}/${pkgName}.git`]);
     });
 });
 
@@ -168,8 +168,29 @@ gulp.task(`package`, () => {
     });
 });
 
+gulp.task(`clean:docs`, () => {
+    return del([`${paths.docs}/*`]);
+});
+
+gulp.task(`clean:manual`, () => {
+    return del([`${paths.manual}/*`]);
+});
+
+gulp.task(`setup`, [`clean`], () => {
+    let log = [
+        mkdirp(paths.docs),
+        mkdirp(paths.manual)
+    ];
+
+    return Promise.all(log).then((response) => {
+        return response;
+    });
+});
+
+gulp.task(`clean`, [`clean:docs`, `clean:manual`]);
 gulp.task(`test:install`, [`nsp`, `snyk`, `bithound`]);
 gulp.task(`test:publish`, [`test:install`, `package`]);
 gulp.task(`prepublish`, [`test:publish`]);
+gulp.task(`pretest`, [`setup`]);
 gulp.task(`test`, [`test:install`, `lint`]);
 gulp.task(`default`, [`test`]);

package.json

@@ -33,19 +33,20 @@
   "homepage": "https://github.com/superleap/github-issues-label-sync#readme",
   "dependencies": {
     "bluebird": "^3.4.1",
-    "github": "^2.1.0"
+    "github": "^2.3.0"
   },
   "devDependencies": {
     "@semantic-release/last-release-npm": "https://github.com/vrtxf/last-release-npm/tarball/da5a0f2411e2add6f5b0b990b4a12fad3245cfac",
-    "babel-core": "^6.10.4",
+    "babel-core": "^6.11.4",
     "babel-plugin-add-module-exports": "^0.2.1",
     "babel-plugin-transform-es2015-block-scoping": "^6.10.1",
     "babel-preset-es2015": "^6.9.0",
-    "babel-register": "^6.9.0",
-    "bithound": "^1.6.0",
+    "babel-register": "^6.11.6",
+    "bithound": "https://github.com/vrtxf/cli.bithound.io/tarball/161a72d925c33876780bfebbfe2e4611cb99e7f0",
     "commitizen": "^2.8.2",
     "conventional-changelog": "^1.1.0",
     "cz-conventional-changelog": "^1.1.6",
+    "del": "^2.2.1",
     "esdoc": "^0.4.7",
     "esdoc-hacker-vision": "^1.1.0",
     "esdoc-node": "^1.0.0",
@@ -60,13 +61,14 @@
     "gulp-istanbul": "^1.0.0",
     "gulp-load-plugins": "^1.2.4",
     "gulp-mocha": "^2.2.0",
-    "gulp-nsp": "^2.4.1",
+    "gulp-nsp": "^2.4.2",
     "gulp-plumber": "^1.1.0",
+    "mkdirp": "^0.5.1",
     "mocha": "^2.5.3",
-    "nsp": "^2.6.0",
+    "nsp": "^2.6.1",
     "read-package-json": "^2.0.4",
     "semantic-release": "^6.3.0",
-    "snyk": "^1.17.1"
+    "snyk": "^1.17.4"
   },
   "config": {
     "commitizen": {