Skip to content
This repository was archived by the owner on Dec 31, 2022. It is now read-only.

Commit fd8e448

Browse files
authored
Merge pull request #19 from peter279k/improve_assertions
Improve PHPUnit assertions
2 parents 5fab4ff + 824933b commit fd8e448

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/ServerRequestTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -203,14 +203,14 @@ public function testSetAttributes() : void
203203
{
204204
$request = new ServerRequest();
205205
$this->assertSame([], $request->getAttributes());
206-
$this->assertSame(null, $request->getAttribute('foo'));
207-
$this->assertSame(false, $request->getAttribute('foo', false));
206+
$this->assertNull($request->getAttribute('foo'));
207+
$this->assertFalse($request->getAttribute('foo', false));
208208

209209
$clone = $request->withAttribute('foo', 'bar');
210210
$this->assertInstanceOf(ServerRequestInterface::class, $clone);
211211
$this->assertNotSame($request, $clone);
212212
$this->assertSame([], $request->getAttributes());
213-
$this->assertSame(null, $request->getAttribute('foo'));
213+
$this->assertNull($request->getAttribute('foo'));
214214
$this->assertSame(['foo' => 'bar'], $clone->getAttributes());
215215
$this->assertSame('bar', $clone->getAttribute('foo'));
216216
}
@@ -228,6 +228,6 @@ public function testRemoveAttributes() : void
228228
$this->assertSame(['foo' => 'bar'], $request->getAttributes());
229229
$this->assertSame('bar', $request->getAttribute('foo'));
230230
$this->assertSame([], $clone->getAttributes());
231-
$this->assertSame(null, $clone->getAttribute('foo'));
231+
$this->assertNull($clone->getAttribute('foo'));
232232
}
233233
}

0 commit comments

Comments
 (0)