From a2b3693767ed098c71e74506886c6111090cfcba Mon Sep 17 00:00:00 2001 From: rois1995 Date: Wed, 26 Mar 2025 14:16:59 +0100 Subject: [PATCH 01/17] - Fix Normal Distance bug --- Common/include/geometry/CGeometry.hpp | 7 +++++++ Common/include/geometry/CPhysicalGeometry.hpp | 7 +++++++ Common/src/geometry/CGeometry.cpp | 15 ++++++++++++++- Common/src/geometry/CPhysicalGeometry.cpp | 4 +++- 4 files changed, 31 insertions(+), 2 deletions(-) diff --git a/Common/include/geometry/CGeometry.hpp b/Common/include/geometry/CGeometry.hpp index 9519877e2533..3e556918d637 100644 --- a/Common/include/geometry/CGeometry.hpp +++ b/Common/include/geometry/CGeometry.hpp @@ -1843,6 +1843,13 @@ class CGeometry { */ virtual void SetWallDistance(su2double val) {} + /*! + * \brief Set wall distances a specific value and at a specific point + * \param[in] iPoint - i-th point to set the wall distance. + * \param[in] val - new value for the wall distance at the input point. + */ + virtual void SetWallDistance(unsigned long iPoint, su2double val) {} + /*! * \brief Compute the distances to the closest vertex on viscous walls over the entire domain * \param[in] config_container - Definition of the particular problem. diff --git a/Common/include/geometry/CPhysicalGeometry.hpp b/Common/include/geometry/CPhysicalGeometry.hpp index 406b4c49c2c9..16c2893bf6e0 100644 --- a/Common/include/geometry/CPhysicalGeometry.hpp +++ b/Common/include/geometry/CPhysicalGeometry.hpp @@ -811,6 +811,13 @@ class CPhysicalGeometry final : public CGeometry { } } + /*! + * \brief Set wall distance of i-th point to a specific value + */ + void SetWallDistance(unsigned long iPoint, su2double val) override { + nodes->SetWall_Distance(iPoint, val); + } + /*! * \brief For streamwise periodicity, find & store a unique reference node on the designated periodic inlet. * \param[in] config - Definition of the particular problem. diff --git a/Common/src/geometry/CGeometry.cpp b/Common/src/geometry/CGeometry.cpp index 0bd1a4bf8eef..664dd41249f4 100644 --- a/Common/src/geometry/CGeometry.cpp +++ b/Common/src/geometry/CGeometry.cpp @@ -4119,7 +4119,20 @@ void CGeometry::ComputeWallDistance(const CConfig* const* config_container, CGeo * This is necessary, because before a computed distance is set, it will be checked * whether the new distance is smaller than the currently stored one. ---*/ CGeometry* geometry = geometry_container[iZone][iInst][MESH_0]; - if (wallDistanceNeeded[iZone]) geometry->SetWallDistance(numeric_limits::max()); + if (wallDistanceNeeded[iZone]){ + geometry->SetWallDistance(numeric_limits::max()); + + const auto nMarker = geometry->GetnMarker(); + for (auto iMarker = 0; iMarker < config_container[iZone]->GetnMarker_All(); iMarker++) { + if (!config_container[iZone]->GetViscous_Wall(iMarker)) continue; + + SU2_OMP_FOR_STAT(OMP_MIN_SIZE) + for (auto iVertex = 0u; iVertex < geometry->nVertex[iMarker]; iVertex++) { + const auto iPoint = geometry->vertex[iMarker][iVertex]->GetNode(); + geometry->SetWallDistance(iPoint, 0.0); + } + } + } } /*--- Loop over all zones and compute the ADT based on the viscous walls in that zone ---*/ diff --git a/Common/src/geometry/CPhysicalGeometry.cpp b/Common/src/geometry/CPhysicalGeometry.cpp index eab91fca43cb..682afd529f79 100644 --- a/Common/src/geometry/CPhysicalGeometry.cpp +++ b/Common/src/geometry/CPhysicalGeometry.cpp @@ -10559,7 +10559,9 @@ void CPhysicalGeometry::SetWallDistance(CADTElemClass* WallADT, const CConfig* c WallADT->DetermineNearestElement(nodes->GetCoord(iPoint), dist, markerID, elemID, rankID); - if (dist < nodes->GetWall_Distance(iPoint)) { + if (nodes->GetWall_Distance(iPoint) == 0) dist = 0; + + if (dist < nodes->GetWall_Distance(iPoint) || dist == 0) { nodes->SetWall_Distance(iPoint, dist, rankID, iZone, markerID, elemID); } } From d882e5d0091c2461f6ac98d0b73f0cd9ecd9625e Mon Sep 17 00:00:00 2001 From: rois1995 Date: Wed, 26 Mar 2025 14:23:37 +0100 Subject: [PATCH 02/17] - pre-commit fixes --- Common/include/geometry/CPhysicalGeometry.hpp | 4 +--- Common/src/geometry/CGeometry.cpp | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/Common/include/geometry/CPhysicalGeometry.hpp b/Common/include/geometry/CPhysicalGeometry.hpp index 16c2893bf6e0..62ae212ab5f5 100644 --- a/Common/include/geometry/CPhysicalGeometry.hpp +++ b/Common/include/geometry/CPhysicalGeometry.hpp @@ -814,9 +814,7 @@ class CPhysicalGeometry final : public CGeometry { /*! * \brief Set wall distance of i-th point to a specific value */ - void SetWallDistance(unsigned long iPoint, su2double val) override { - nodes->SetWall_Distance(iPoint, val); - } + void SetWallDistance(unsigned long iPoint, su2double val) override { nodes->SetWall_Distance(iPoint, val); } /*! * \brief For streamwise periodicity, find & store a unique reference node on the designated periodic inlet. diff --git a/Common/src/geometry/CGeometry.cpp b/Common/src/geometry/CGeometry.cpp index 664dd41249f4..2788c76f8575 100644 --- a/Common/src/geometry/CGeometry.cpp +++ b/Common/src/geometry/CGeometry.cpp @@ -4119,7 +4119,7 @@ void CGeometry::ComputeWallDistance(const CConfig* const* config_container, CGeo * This is necessary, because before a computed distance is set, it will be checked * whether the new distance is smaller than the currently stored one. ---*/ CGeometry* geometry = geometry_container[iZone][iInst][MESH_0]; - if (wallDistanceNeeded[iZone]){ + if (wallDistanceNeeded[iZone]) { geometry->SetWallDistance(numeric_limits::max()); const auto nMarker = geometry->GetnMarker(); @@ -4132,7 +4132,7 @@ void CGeometry::ComputeWallDistance(const CConfig* const* config_container, CGeo geometry->SetWallDistance(iPoint, 0.0); } } - } + } } /*--- Loop over all zones and compute the ADT based on the viscous walls in that zone ---*/ From 0140f2fef19464668d51bf0b6eab7f8e2f6b3ea5 Mon Sep 17 00:00:00 2001 From: rois1995 Date: Wed, 26 Mar 2025 14:35:35 +0100 Subject: [PATCH 03/17] - correct compilation error --- Common/src/geometry/CGeometry.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/Common/src/geometry/CGeometry.cpp b/Common/src/geometry/CGeometry.cpp index 2788c76f8575..868c90d9f264 100644 --- a/Common/src/geometry/CGeometry.cpp +++ b/Common/src/geometry/CGeometry.cpp @@ -4122,7 +4122,6 @@ void CGeometry::ComputeWallDistance(const CConfig* const* config_container, CGeo if (wallDistanceNeeded[iZone]) { geometry->SetWallDistance(numeric_limits::max()); - const auto nMarker = geometry->GetnMarker(); for (auto iMarker = 0; iMarker < config_container[iZone]->GetnMarker_All(); iMarker++) { if (!config_container[iZone]->GetViscous_Wall(iMarker)) continue; From 5f9cd9c80aa0e497602db6c6ddecac1fc484086a Mon Sep 17 00:00:00 2001 From: rois1995 Date: Wed, 26 Mar 2025 15:14:17 +0100 Subject: [PATCH 04/17] - Fix compilation error --- Common/src/geometry/CPhysicalGeometry.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Common/src/geometry/CPhysicalGeometry.cpp b/Common/src/geometry/CPhysicalGeometry.cpp index 682afd529f79..369e21910a66 100644 --- a/Common/src/geometry/CPhysicalGeometry.cpp +++ b/Common/src/geometry/CPhysicalGeometry.cpp @@ -10559,9 +10559,10 @@ void CPhysicalGeometry::SetWallDistance(CADTElemClass* WallADT, const CConfig* c WallADT->DetermineNearestElement(nodes->GetCoord(iPoint), dist, markerID, elemID, rankID); - if (nodes->GetWall_Distance(iPoint) == 0) dist = 0; + // if (nodes->GetWall_Distance(iPoint) == 0) dist = 0; - if (dist < nodes->GetWall_Distance(iPoint) || dist == 0) { + // if (dist < nodes->GetWall_Distance(iPoint) || dist == 0) { + if (dist < nodes->GetWall_Distance(iPoint)) { nodes->SetWall_Distance(iPoint, dist, rankID, iZone, markerID, elemID); } } From c40f17b88f5499de7b6ad09d83801edc8714c250 Mon Sep 17 00:00:00 2001 From: rois1995 Date: Wed, 26 Mar 2025 15:14:40 +0100 Subject: [PATCH 05/17] - fix compilation error --- Common/src/geometry/CGeometry.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/Common/src/geometry/CGeometry.cpp b/Common/src/geometry/CGeometry.cpp index 868c90d9f264..e8f2f7621af1 100644 --- a/Common/src/geometry/CGeometry.cpp +++ b/Common/src/geometry/CGeometry.cpp @@ -4130,6 +4130,7 @@ void CGeometry::ComputeWallDistance(const CConfig* const* config_container, CGeo const auto iPoint = geometry->vertex[iMarker][iVertex]->GetNode(); geometry->SetWallDistance(iPoint, 0.0); } + END_SU2_OMP_FOR } } } From 83e7e7f05a3fb9359b43e7405285d7194e4e1bc6 Mon Sep 17 00:00:00 2001 From: rois1995 Date: Wed, 26 Mar 2025 15:15:55 +0100 Subject: [PATCH 06/17] - revert changes --- Common/src/geometry/CPhysicalGeometry.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Common/src/geometry/CPhysicalGeometry.cpp b/Common/src/geometry/CPhysicalGeometry.cpp index 369e21910a66..682afd529f79 100644 --- a/Common/src/geometry/CPhysicalGeometry.cpp +++ b/Common/src/geometry/CPhysicalGeometry.cpp @@ -10559,10 +10559,9 @@ void CPhysicalGeometry::SetWallDistance(CADTElemClass* WallADT, const CConfig* c WallADT->DetermineNearestElement(nodes->GetCoord(iPoint), dist, markerID, elemID, rankID); - // if (nodes->GetWall_Distance(iPoint) == 0) dist = 0; + if (nodes->GetWall_Distance(iPoint) == 0) dist = 0; - // if (dist < nodes->GetWall_Distance(iPoint) || dist == 0) { - if (dist < nodes->GetWall_Distance(iPoint)) { + if (dist < nodes->GetWall_Distance(iPoint) || dist == 0) { nodes->SetWall_Distance(iPoint, dist, rankID, iZone, markerID, elemID); } } From 2fb60aa71f793d2b4778fd97ccbbc061109d1457 Mon Sep 17 00:00:00 2001 From: rois1995 Date: Wed, 26 Mar 2025 18:47:22 +0100 Subject: [PATCH 07/17] - Update regression cases --- TestCases/parallel_regression.py | 4 ++-- TestCases/tutorials.py | 4 ++-- TestCases/vandv.py | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/TestCases/parallel_regression.py b/TestCases/parallel_regression.py index 96e2dd866a1b..cf9fda9812d3 100644 --- a/TestCases/parallel_regression.py +++ b/TestCases/parallel_regression.py @@ -397,7 +397,7 @@ def main(): turb_flatplate_CC_Wilcox.cfg_dir = "rans/flatplate" turb_flatplate_CC_Wilcox.cfg_file = "turb_SST_flatplate_compressibility_Wilcox.cfg" turb_flatplate_CC_Wilcox.test_iter = 20 - turb_flatplate_CC_Wilcox.test_vals = [-1.280875, 1.974210, 1.440441, 5.038396, -3.791318, 11.809748] + turb_flatplate_CC_Wilcox.test_vals = [-1.280875, 1.974210, 1.440441, 5.038396, -3.791093, 8.297424] test_list.append(turb_flatplate_CC_Wilcox) # Flat plate SST compressibility correction Sarkar @@ -405,7 +405,7 @@ def main(): turb_flatplate_CC_Sarkar.cfg_dir = "rans/flatplate" turb_flatplate_CC_Sarkar.cfg_file = "turb_SST_flatplate_compressibility_Sarkar.cfg" turb_flatplate_CC_Sarkar.test_iter = 20 - turb_flatplate_CC_Sarkar.test_vals = [-1.280875, 1.974210, 1.440441, 5.038396, -3.791321, 11.809748] + turb_flatplate_CC_Sarkar.test_vals = [-1.280875, 1.974210, 1.440441, 5.038396, -3.791096, 8.297424] test_list.append(turb_flatplate_CC_Sarkar) # ONERA M6 Wing diff --git a/TestCases/tutorials.py b/TestCases/tutorials.py index ef4398b6f751..73cb83e9a8bd 100644 --- a/TestCases/tutorials.py +++ b/TestCases/tutorials.py @@ -236,7 +236,7 @@ def main(): tutorial_trans_flatplate_T3A.cfg_dir = "../Tutorials/compressible_flow/Transitional_Flat_Plate/Langtry_and_Menter/T3A" tutorial_trans_flatplate_T3A.cfg_file = "transitional_LM_model_ConfigFile.cfg" tutorial_trans_flatplate_T3A.test_iter = 20 - tutorial_trans_flatplate_T3A.test_vals = [-5.841218, -2.094611, -3.947011, -0.305590, -1.586230, 8.296809, -3.507308, 0.394898] + tutorial_trans_flatplate_T3A.test_vals = [-5.837370, -2.092243, -3.983811, -0.302357, -1.937550, 1.768072, -3.496905, 0.391385] tutorial_trans_flatplate_T3A.test_vals_aarch64 = [-5.837368, -2.092246, -3.984172, -0.302357, -1.928108, 1.667157, -3.496279, 0.391610] tutorial_trans_flatplate_T3A.no_restart = True test_list.append(tutorial_trans_flatplate_T3A) @@ -246,7 +246,7 @@ def main(): tutorial_trans_flatplate_T3Am.cfg_dir = "../Tutorials/compressible_flow/Transitional_Flat_Plate/Langtry_and_Menter/T3A-" tutorial_trans_flatplate_T3Am.cfg_file = "transitional_LM_model_ConfigFile.cfg" tutorial_trans_flatplate_T3Am.test_iter = 20 - tutorial_trans_flatplate_T3Am.test_vals = [-6.206421, -2.029271, -4.028227, -0.685277, -3.893712, 6.692342, -2.521007, 0.948646] + tutorial_trans_flatplate_T3Am.test_vals = [-6.063710, -1.945074, -3.946905, -0.549154, -3.863803, 2.662907, -2.517658, 1.112973] tutorial_trans_flatplate_T3Am.test_vals_aarch64 = [-6.063726, -1.945088, -3.946923, -0.549166, -3.863794, 2.664439, -2.517601, 1.112978] tutorial_trans_flatplate_T3Am.no_restart = True test_list.append(tutorial_trans_flatplate_T3Am) diff --git a/TestCases/vandv.py b/TestCases/vandv.py index 1978292f7481..1df61efe0f2d 100644 --- a/TestCases/vandv.py +++ b/TestCases/vandv.py @@ -63,8 +63,8 @@ def main(): bump_sst1994m.cfg_dir = "vandv/rans/bump_in_channel" bump_sst1994m.cfg_file = "turb_bump_sst.cfg" bump_sst1994m.test_iter = 5 - bump_sst1994m.test_vals = [-13.006002, -10.671005, -10.602936, -7.625336, -10.992230, -0.224690, 0.004900] - bump_sst1994m.test_vals_aarch64 = [-13.006002, -10.671005, -10.602936, -7.625336, -10.992230, -0.224690, 0.004900] + bump_sst1994m.test_vals = [-13.01855, -10.667222, -10.574287, -7.568941, -10.709443, -5.454146, 0.004903] + bump_sst1994m.test_vals_aarch64 = [-13.01855, -10.667222, -10.574287, -7.568941, -10.709443, -5.454146, 0.004903] test_list.append(bump_sst1994m) # SWBLI SA From 1df83130135378922a2cac86f4994f05faf72d4f Mon Sep 17 00:00:00 2001 From: rois1995 Date: Wed, 26 Mar 2025 18:56:39 +0100 Subject: [PATCH 08/17] - change test cases branch --- .github/workflows/regression.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regression.yml b/.github/workflows/regression.yml index 2502204b64c4..0cea4ead39dc 100644 --- a/.github/workflows/regression.yml +++ b/.github/workflows/regression.yml @@ -209,7 +209,7 @@ jobs: uses: docker://ghcr.io/su2code/su2/test-su2:240320-1536 with: # -t -c - args: -b ${{github.ref}} -t develop -c develop -s ${{matrix.testscript}} + args: -b ${{github.ref}} -t fix_NormalNeighborDistance -c develop -s ${{matrix.testscript}} - name: Cleanup uses: docker://ghcr.io/su2code/su2/test-su2:240320-1536 with: From dc65cd8b97dc77c703003c41b847f80fbc85bf31 Mon Sep 17 00:00:00 2001 From: rois1995 Date: Wed, 26 Mar 2025 20:00:07 +0100 Subject: [PATCH 09/17] - revert changes and put fix in the NearestNeighborDistance --- Common/src/geometry/CGeometry.cpp | 18 +++--------------- Common/src/geometry/CPhysicalGeometry.cpp | 4 +--- 2 files changed, 4 insertions(+), 18 deletions(-) diff --git a/Common/src/geometry/CGeometry.cpp b/Common/src/geometry/CGeometry.cpp index e8f2f7621af1..ed853fb16619 100644 --- a/Common/src/geometry/CGeometry.cpp +++ b/Common/src/geometry/CGeometry.cpp @@ -4074,7 +4074,8 @@ su2double NearestNeighborDistance(CGeometry* geometry, const CConfig* config, co const su2double max = std::numeric_limits::max(); su2double distance = max; for (const auto jPoint : geometry->nodes->GetPoints(iPoint)) { - const su2double dist = geometry->nodes->GetWall_Distance(jPoint); + const su2double dist = + geometry->nodes->GetViscousBoundary(jPoint) ? 0.0 : geometry->nodes->GetWall_Distance(jPoint); if (dist > EPS) distance = fmin(distance, dist); } if (distance > 0 && distance < max) return distance; @@ -4119,20 +4120,7 @@ void CGeometry::ComputeWallDistance(const CConfig* const* config_container, CGeo * This is necessary, because before a computed distance is set, it will be checked * whether the new distance is smaller than the currently stored one. ---*/ CGeometry* geometry = geometry_container[iZone][iInst][MESH_0]; - if (wallDistanceNeeded[iZone]) { - geometry->SetWallDistance(numeric_limits::max()); - - for (auto iMarker = 0; iMarker < config_container[iZone]->GetnMarker_All(); iMarker++) { - if (!config_container[iZone]->GetViscous_Wall(iMarker)) continue; - - SU2_OMP_FOR_STAT(OMP_MIN_SIZE) - for (auto iVertex = 0u; iVertex < geometry->nVertex[iMarker]; iVertex++) { - const auto iPoint = geometry->vertex[iMarker][iVertex]->GetNode(); - geometry->SetWallDistance(iPoint, 0.0); - } - END_SU2_OMP_FOR - } - } + if (wallDistanceNeeded[iZone]) geometry->SetWallDistance(numeric_limits::max()); } /*--- Loop over all zones and compute the ADT based on the viscous walls in that zone ---*/ diff --git a/Common/src/geometry/CPhysicalGeometry.cpp b/Common/src/geometry/CPhysicalGeometry.cpp index 682afd529f79..eab91fca43cb 100644 --- a/Common/src/geometry/CPhysicalGeometry.cpp +++ b/Common/src/geometry/CPhysicalGeometry.cpp @@ -10559,9 +10559,7 @@ void CPhysicalGeometry::SetWallDistance(CADTElemClass* WallADT, const CConfig* c WallADT->DetermineNearestElement(nodes->GetCoord(iPoint), dist, markerID, elemID, rankID); - if (nodes->GetWall_Distance(iPoint) == 0) dist = 0; - - if (dist < nodes->GetWall_Distance(iPoint) || dist == 0) { + if (dist < nodes->GetWall_Distance(iPoint)) { nodes->SetWall_Distance(iPoint, dist, rankID, iZone, markerID, elemID); } } From bca0284c9ec254f408ad8cefbe4ffed36315eb61 Mon Sep 17 00:00:00 2001 From: rois1995 Date: Wed, 26 Mar 2025 20:33:52 +0100 Subject: [PATCH 10/17] - test case branches --- .github/workflows/regression.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regression.yml b/.github/workflows/regression.yml index 0cea4ead39dc..d88466267938 100644 --- a/.github/workflows/regression.yml +++ b/.github/workflows/regression.yml @@ -209,7 +209,7 @@ jobs: uses: docker://ghcr.io/su2code/su2/test-su2:240320-1536 with: # -t -c - args: -b ${{github.ref}} -t fix_NormalNeighborDistance -c develop -s ${{matrix.testscript}} + args: -b ${{github.ref}} -t develop -c fix_NormalNeighborDistance -s ${{matrix.testscript}} - name: Cleanup uses: docker://ghcr.io/su2code/su2/test-su2:240320-1536 with: From fb48919cf5d674f7b2db9c3ca2d39009aaf36152 Mon Sep 17 00:00:00 2001 From: rois1995 Date: Wed, 26 Mar 2025 20:37:44 +0100 Subject: [PATCH 11/17] - small fix to vandv --- TestCases/vandv.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/TestCases/vandv.py b/TestCases/vandv.py index 1df61efe0f2d..bdf5c311d9b6 100644 --- a/TestCases/vandv.py +++ b/TestCases/vandv.py @@ -63,8 +63,8 @@ def main(): bump_sst1994m.cfg_dir = "vandv/rans/bump_in_channel" bump_sst1994m.cfg_file = "turb_bump_sst.cfg" bump_sst1994m.test_iter = 5 - bump_sst1994m.test_vals = [-13.01855, -10.667222, -10.574287, -7.568941, -10.709443, -5.454146, 0.004903] - bump_sst1994m.test_vals_aarch64 = [-13.01855, -10.667222, -10.574287, -7.568941, -10.709443, -5.454146, 0.004903] + bump_sst1994m.test_vals = [-13.018554, -10.667222, -10.574287, -7.568941, -10.709443, -5.454146, 0.004903] + bump_sst1994m.test_vals_aarch64 = [-13.018554, -10.667222, -10.574287, -7.568941, -10.709443, -5.454146, 0.004903] test_list.append(bump_sst1994m) # SWBLI SA From 6276ce32057fd8150dfa2978adce8fb95eb27701 Mon Sep 17 00:00:00 2001 From: Nijso Date: Wed, 26 Mar 2025 21:03:40 +0100 Subject: [PATCH 12/17] Update Common/include/geometry/CGeometry.hpp Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com> --- Common/include/geometry/CGeometry.hpp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/Common/include/geometry/CGeometry.hpp b/Common/include/geometry/CGeometry.hpp index 3e556918d637..9519877e2533 100644 --- a/Common/include/geometry/CGeometry.hpp +++ b/Common/include/geometry/CGeometry.hpp @@ -1843,13 +1843,6 @@ class CGeometry { */ virtual void SetWallDistance(su2double val) {} - /*! - * \brief Set wall distances a specific value and at a specific point - * \param[in] iPoint - i-th point to set the wall distance. - * \param[in] val - new value for the wall distance at the input point. - */ - virtual void SetWallDistance(unsigned long iPoint, su2double val) {} - /*! * \brief Compute the distances to the closest vertex on viscous walls over the entire domain * \param[in] config_container - Definition of the particular problem. From c5ef3ff057a166d5b6c5ac9413daa2d125f5cb4a Mon Sep 17 00:00:00 2001 From: Nijso Date: Wed, 26 Mar 2025 21:03:47 +0100 Subject: [PATCH 13/17] Update Common/include/geometry/CPhysicalGeometry.hpp Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com> --- Common/include/geometry/CPhysicalGeometry.hpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/Common/include/geometry/CPhysicalGeometry.hpp b/Common/include/geometry/CPhysicalGeometry.hpp index 62ae212ab5f5..406b4c49c2c9 100644 --- a/Common/include/geometry/CPhysicalGeometry.hpp +++ b/Common/include/geometry/CPhysicalGeometry.hpp @@ -811,11 +811,6 @@ class CPhysicalGeometry final : public CGeometry { } } - /*! - * \brief Set wall distance of i-th point to a specific value - */ - void SetWallDistance(unsigned long iPoint, su2double val) override { nodes->SetWall_Distance(iPoint, val); } - /*! * \brief For streamwise periodicity, find & store a unique reference node on the designated periodic inlet. * \param[in] config - Definition of the particular problem. From 23de022d29a4b906df4e6ce1875291d52017bdd4 Mon Sep 17 00:00:00 2001 From: rois1995 Date: Wed, 26 Mar 2025 22:48:34 +0100 Subject: [PATCH 14/17] - fix VAndV --- TestCases/vandv.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/TestCases/vandv.py b/TestCases/vandv.py index bdf5c311d9b6..540c6e494225 100644 --- a/TestCases/vandv.py +++ b/TestCases/vandv.py @@ -63,8 +63,8 @@ def main(): bump_sst1994m.cfg_dir = "vandv/rans/bump_in_channel" bump_sst1994m.cfg_file = "turb_bump_sst.cfg" bump_sst1994m.test_iter = 5 - bump_sst1994m.test_vals = [-13.018554, -10.667222, -10.574287, -7.568941, -10.709443, -5.454146, 0.004903] - bump_sst1994m.test_vals_aarch64 = [-13.018554, -10.667222, -10.574287, -7.568941, -10.709443, -5.454146, 0.004903] + bump_sst1994m.test_vals = [-13.025265, -10.669816, -10.615338, -7.577125, -10.709448, -5.453868, 0.004903] + bump_sst1994m.test_vals_aarch64 = [-13.025265, -10.669816, -10.615338, -7.577125, -10.709448, -5.453868, 0.004903] test_list.append(bump_sst1994m) # SWBLI SA From 15e2c83e98402a236612e026e3e57b5eb6fc190c Mon Sep 17 00:00:00 2001 From: rois1995 Date: Thu, 27 Mar 2025 18:33:52 +0100 Subject: [PATCH 15/17] - Fix MLPCpp --- subprojects/MLPCpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/MLPCpp b/subprojects/MLPCpp index e19ca0cafb28..6865a58b22f2 160000 --- a/subprojects/MLPCpp +++ b/subprojects/MLPCpp @@ -1 +1 @@ -Subproject commit e19ca0cafb28c4b7ba5b8cffef42883259b00dc0 +Subproject commit 6865a58b22f21a92977839d9c93eae9522402f55 From 782fa901181e2f24734634d44c4fac5bd254e626 Mon Sep 17 00:00:00 2001 From: rois1995 Date: Thu, 27 Mar 2025 18:33:57 +0100 Subject: [PATCH 16/17] Fix MLPCpp --- subprojects/MLPCpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/MLPCpp b/subprojects/MLPCpp index 6865a58b22f2..e19ca0cafb28 160000 --- a/subprojects/MLPCpp +++ b/subprojects/MLPCpp @@ -1 +1 @@ -Subproject commit 6865a58b22f21a92977839d9c93eae9522402f55 +Subproject commit e19ca0cafb28c4b7ba5b8cffef42883259b00dc0 From f2bbf42182b93ef6df99c97573d387a5bf708e1d Mon Sep 17 00:00:00 2001 From: rois1995 Date: Thu, 27 Mar 2025 18:34:27 +0100 Subject: [PATCH 17/17] - Fix regression branch --- .github/workflows/regression.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/regression.yml b/.github/workflows/regression.yml index d6a301461093..cef9d68216ed 100644 --- a/.github/workflows/regression.yml +++ b/.github/workflows/regression.yml @@ -209,7 +209,7 @@ jobs: uses: docker://ghcr.io/su2code/su2/test-su2:240320-1536 with: # -t -c - args: -b ${{github.ref}} -t develop -c fix_NormalNeighborDistance -s ${{matrix.testscript}} + args: -b ${{github.ref}} -t develop -c develop -s ${{matrix.testscript}} - name: Cleanup uses: docker://ghcr.io/su2code/su2/test-su2:240320-1536 with: