Skip to content

Fix 28 Implement SDP of MASS_V4#30

Open
NimaSarajpoor wants to merge 4 commits into
mainfrom
sdp_mass_v4
Open

Fix 28 Implement SDP of MASS_V4#30
NimaSarajpoor wants to merge 4 commits into
mainfrom
sdp_mass_v4

Conversation

@NimaSarajpoor

@NimaSarajpoor NimaSarajpoor commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

This PR is to address #28.

@gitnotebooks

gitnotebooks Bot commented Jan 4, 2026

Copy link
Copy Markdown

Comment thread sdp/challenger_sdp.py Outdated
@NimaSarajpoor

NimaSarajpoor commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator Author

According to the following plot, challenger_sdp (blue) does not show a good performance. Note that the batch-processing part of "MASS_V4" has not been added yet to challenger_sdp. The following plot (most likely) confirms that we cannot just use Discrete-Cosine-Transform(DCT)-based SDP alone and we may need to add that batch processing piece, and use this algo for large n (>= 2^20).

./timing.py -timeout 1.0 -pmin 6 -pmax 20 pyfftw challenger pocketfft_r2c_c2r scipy_oaconvolve > timing.csv
MASS_V4_Performance_Comparison

@seanlaw

seanlaw commented Jan 4, 2026

Copy link
Copy Markdown
Contributor

Yeah, it looks pretty bad right now! Fingers crossed that things improve. Otherwise, we should/could reach out to the authors.

I find it curious that DCT is found in scipy.fft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants