Skip to content

Commit 4a7bd3d

Browse files
authored
Merge branch 'main' into dockerfile
2 parents 31ed462 + aef2923 commit 4a7bd3d

6 files changed

Lines changed: 28 additions & 5 deletions

File tree

.cargo/config.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
[alias] # command aliases
44
f = "fmt"
5-
md-gen = "run --package doc-gen"
65
s = "run --quiet --"
76
# b = "build"
87
# c = "check"

.github/workflows/binaries.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ jobs:
205205
if:
206206
github.event_name == 'release' || startsWith(github.ref, 'refs/heads/release/') || startsWith(github.head_ref, 'release/')
207207
id: stm-setup
208-
uses: digicert/code-signing-software-trust-action@v1.0.1
208+
uses: digicert/code-signing-software-trust-action@v1.1.0
209209
with:
210210
simple-signing-mode: true
211211
keypair-alias: key_1412258126

Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ rust-version = "1.89.0"
2828
[workspace.dependencies.soroban-cli]
2929
version = "=25.1.0"
3030
path = "cmd/soroban-cli"
31+
default-features = false
3132

3233
[workspace.dependencies.soroban-spec-typescript]
3334
version = "25.1.0"

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ build-test-wasms:
4444
build-test: build-test-wasms install
4545

4646
docs:
47-
cargo run --package doc-gen
47+
cargo run --package doc-gen --features additional-libs
4848
./node_modules/.bin/prettier --write --log-level warn FULL_HELP_DOCS.md
4949

5050
test: build-test

cmd/doc-gen/Cargo.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ edition = "2021"
1111
rust-version.workspace = true
1212
publish = false
1313

14+
[features]
15+
additional-libs = ["soroban-cli/additional-libs"]
16+
1417
[dependencies]
1518
soroban-cli = { workspace = true }
1619
# clap-markdown from https://github.com/ConnorGray/clap-markdown/pull/48

cmd/soroban-cli/src/commands/doctor.rs

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ impl Cmd {
4848
check_version(&print).await?;
4949
check_rust_version(&print);
5050
check_wasm_target(&print);
51+
check_optional_features(&print);
5152
show_config_path(&print, &self.config_locator)?;
5253
show_data_path(&print)?;
5354
show_xdr_version(&print);
@@ -98,8 +99,8 @@ async fn print_network(
9899
};
99100

100101
print.globeln(format!("{prefix} {name:?} ({})", network.rpc_url,));
101-
print.blankln(format!(" protocol {}", version_info.protocol_version));
102-
print.blankln(format!(" rpc {}", version_info.version));
102+
print.blankln(format!("protocol {}", version_info.protocol_version));
103+
print.blankln(format!("rpc {}", version_info.version));
103104

104105
Ok(())
105106
}
@@ -200,6 +201,25 @@ fn check_wasm_target(print: &Print) {
200201
}
201202
}
202203

204+
fn check_optional_features(print: &Print) {
205+
#[cfg(feature = "additional-libs")]
206+
{
207+
print.checkln("Wasm optimization");
208+
print.checkln("Secure store (OS keyring)");
209+
print.checkln("Ledger hardware wallet");
210+
}
211+
212+
#[cfg(not(feature = "additional-libs"))]
213+
{
214+
print.warnln(
215+
"The following features are disabled until `--features additional-libs` is used:",
216+
);
217+
print.blankln("- Wasm optimization");
218+
print.blankln("- Secure store (OS keyring)");
219+
print.blankln("- Ledger hardware wallet");
220+
}
221+
}
222+
203223
fn get_expected_wasm_target() -> String {
204224
let Ok(current_version) = version() else {
205225
return "wasm32v1-none".into();

0 commit comments

Comments
 (0)