Clean up health check dead code and timeout

The constructor and functional options guarantee positive values
for healthCheckInterval and healthCheckPingTimeout, making two
zero-value guards unreachable. The redundant context timeout in
checkMCPStatus capped the configurable ping timeout at 5s; the
MCPPinger already enforces its own timeout internally.

Fixes #4790

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Greg Katz <gkatz@indeed.com>

Author: gkatz2

pkg/healthcheck/healthcheck.go

@@ -106,11 +106,7 @@ func (hc *HealthChecker) checkMCPStatus(ctx context.Context) *MCPStatus {
 		LastChecked: time.Now(),
 	}
 
-	// Create a context with timeout for the ping
-	pingCtx, cancel := context.WithTimeout(ctx, 5*time.Second)
-	defer cancel()
-
-	duration, err := hc.mcpPinger.Ping(pingCtx)
+	duration, err := hc.mcpPinger.Ping(ctx)
 
 	if err != nil {
 		status.Available = false

pkg/transport/proxy/transparent/transparent_proxy.go

@@ -456,14 +456,10 @@ func NewTransparentProxyWithOptions(
 	// Create health checker always for Kubernetes probes
 	var mcpPinger healthcheck.MCPPinger
 	if enableHealthCheck {
-		pingTimeout := proxy.healthCheckPingTimeout
-		if pingTimeout == 0 {
-			pingTimeout = DefaultPingerTimeout
-		}
 		if proxy.stateless {
-			mcpPinger = NewStatelessMCPPingerWithTimeout(targetURI, pingTimeout)
+			mcpPinger = NewStatelessMCPPingerWithTimeout(targetURI, proxy.healthCheckPingTimeout)
 		} else {
-			mcpPinger = NewMCPPingerWithTimeout(targetURI, pingTimeout)
+			mcpPinger = NewMCPPingerWithTimeout(targetURI, proxy.healthCheckPingTimeout)
 		}
 	}
 	proxy.healthChecker = healthcheck.NewHealthChecker(transportType, mcpPinger)
@@ -1246,11 +1242,7 @@ func (p *TransparentProxy) handleHealthCheckFailure(
 }
 
 func (p *TransparentProxy) monitorHealth(parentCtx context.Context) {
-	interval := p.healthCheckInterval
-	if interval == 0 {
-		interval = DefaultHealthCheckInterval
-	}
-	ticker := time.NewTicker(interval)
+	ticker := time.NewTicker(p.healthCheckInterval)
 	defer ticker.Stop()
 
 	consecutiveFailures := 0