apply PR suggestions: #1198

Author: david-mey-STACKIT

docs/data-sources/alb.md …ata-sources/application_load_balancer.mddocs/data-sources/alb.md renamed to docs/data-sources/application_load_balancer.md docs/data-sources/alb.md renamed to docs/data-sources/application_load_balancer.md

@@ -1,23 +1,19 @@
 ---
 # generated by https://github.com/hashicorp/terraform-plugin-docs
-page_title: "stackit_alb Data Source - stackit"
+page_title: "stackit_application_load_balancer Data Source - stackit"
 subcategory: ""
 description: |-
-  Setting up supporting infrastructure
-  The example below creates the supporting infrastructure using the STACKIT Terraform provider, including the network, network interface, a public IP address and server resources.
+  Application Load Balancer data source schema. Must have a region specified in the provider configuration.
 ---
 
-# stackit_alb (Data Source)
+# stackit_application_load_balancer (Data Source)
 
-## Setting up supporting infrastructure
-
-
-The example below creates the supporting infrastructure using the STACKIT Terraform provider, including the network, network interface, a public IP address and server resources.
+Application Load Balancer data source schema. Must have a region specified in the provider configuration.
 
 ## Example Usage
 
 ```terraform
-data "stackit_alb" "example" {
+data "stackit_application_load_balancer" "example" {
   project_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
   name       = "example-load-balancer"
 }
@@ -36,16 +32,15 @@ data "stackit_alb" "example" {
 - `disable_target_security_group_assignment` (Boolean) Disable target security group assignemt to allow targets outside of the given network. Connectivity to targets need to be ensured by the customer, including routing and Security Groups (targetSecurityGroup can be assigned). Not changeable after creation.
 - `errors` (Attributes Set) Reports all errors a Application Load Balancer has. (see [below for nested schema](#nestedatt--errors))
 - `external_address` (String) The external IP address where this Application Load Balancer is exposed. Not changeable after creation.
-- `id` (String) Terraform's internal resource ID. It is structured as "`project_id`","region","`name`".
+- `id` (String) Terraform's internal resource ID. It is structured as `project_id`,`region`,`name`.
 - `labels` (Map of String) Labels represent user-defined metadata as key-value pairs. Label count cannot exceed 64 per ALB.
 - `listeners` (Attributes List) List of all listeners which will accept traffic. Limited to 20. (see [below for nested schema](#nestedatt--listeners))
 - `load_balancer_security_group` (Attributes) Security Group permitting network traffic from the LoadBalancer to the targets. Useful when disableTargetSecurityGroupAssignment=true to manually assign target security groups to targets. (see [below for nested schema](#nestedatt--load_balancer_security_group))
 - `networks` (Attributes Set) List of networks that listeners and targets reside in. (see [below for nested schema](#nestedatt--networks))
 - `options` (Attributes) Defines any optional functionality you want to have enabled on your Application Load Balancer. (see [below for nested schema](#nestedatt--options))
-- `plan_id` (String) Service Plan configures the size of the Application Load Balancer. Possible values are: `p10`.. This list can change in the future. Therefore, this is not an enum.
+- `plan_id` (String) Service Plan configures the size of the Application Load Balancer.
 - `private_address` (String)
-- `region` (String) The resource region. If not defined, the provider region is used. Possible values are: `eu01`, `eu02`.
-- `status` (String) Enum: "STATUS_UNSPECIFIED" "STATUS_PENDING" "STATUS_READY" "STATUS_ERROR" "STATUS_TERMINATING"
+- `region` (String) The resource region. If not defined, the provider region is used.
 - `target_pools` (Attributes List) List of all target pools which will be used in the Application Load Balancer. Limited to 20. (see [below for nested schema](#nestedatt--target_pools))
 - `target_security_group` (Attributes) Security Group that allows the targets to receive traffic from the LoadBalancer. Useful when disableTargetSecurityGroupAssignment=true to manually assign target security groups to targets. (see [below for nested schema](#nestedatt--target_security_group))
 - `version` (String) Application Load Balancer resource version. Used for concurrency safe updates.
@@ -178,11 +173,19 @@ Read-Only:
 
 Read-Only:
 
-- `acl` (Set of String) Use this option to limit the IP ranges that can use the Application Load Balancer.
+- `access_control` (Attributes) Use this option to limit the IP ranges that can use the Application Load Balancer. (see [below for nested schema](#nestedatt--options--access_control))
 - `ephemeral_address` (Boolean) This option automates the handling of the external IP address for an Application Load Balancer. If set to true a new IP address will be automatically created. It will also be automatically deleted when the Load Balancer is deleted.
 - `observability` (Attributes) We offer Load Balancer observability via STACKIT Observability or external solutions. (see [below for nested schema](#nestedatt--options--observability))
 - `private_network_only` (Boolean) Application Load Balancer is accessible only via a private network ip address. Not changeable after creation.
 
+<a id="nestedatt--options--access_control"></a>
+### Nested Schema for `options.access_control`
+
+Read-Only:
+
+- `allowed_source_ranges` (Set of String) Application Load Balancer is accessible only from an IP address in this range.
+
+
 <a id="nestedatt--options--observability"></a>
 ### Nested Schema for `options.observability`
 

docs/resources/alb.md …s/resources/application_load_balancer.mddocs/resources/alb.md renamed to docs/resources/application_load_balancer.md docs/resources/alb.md renamed to docs/resources/application_load_balancer.md

@@ -1,13 +1,13 @@
 ---
 # generated by https://github.com/hashicorp/terraform-plugin-docs
-page_title: "stackit_alb Resource - stackit"
+page_title: "stackit_application_load_balancer Resource - stackit"
 subcategory: ""
 description: |-
   Setting up supporting infrastructure
   The example below creates the supporting infrastructure using the STACKIT Terraform provider, including the network, network interface, a public IP address and server resources.
 ---
 
-# stackit_alb (Resource)
+# stackit_application_load_balancer (Resource)
 
 ## Setting up supporting infrastructure
 
@@ -116,7 +116,7 @@ resource "stackit_loadbalancer_observability_credential" "observability" {
 }
 
 # Create a Application Load Balancer
-resource "stackit_alb" "example" {
+resource "stackit_application_load_balancer" "example" {
   project_id = var.project_id
   region     = "eu01"
   name       = "example-load-balancer"
@@ -238,15 +238,14 @@ resource "stackit_alb" "example" {
 - `external_address` (String) The external IP address where this Application Load Balancer is exposed. Not changeable after creation.
 - `labels` (Map of String) Labels represent user-defined metadata as key-value pairs. Label count cannot exceed 64 per ALB.
 - `options` (Attributes) Defines any optional functionality you want to have enabled on your Application Load Balancer. (see [below for nested schema](#nestedatt--options))
-- `region` (String) The resource region. If not defined, the provider region is used. Possible values are: `eu01`, `eu02`.
+- `region` (String) The resource region (e.g. eu01). If not defined, the provider region is used.
 
 ### Read-Only
 
 - `errors` (Attributes Set) Reports all errors a Application Load Balancer has. (see [below for nested schema](#nestedatt--errors))
-- `id` (String) Terraform's internal resource ID. It is structured as "`project_id`","region","`name`".
+- `id` (String) Terraform's internal resource ID. It is structured as `project_id`,`region`,`name`.
 - `load_balancer_security_group` (Attributes) Security Group permitting network traffic from the LoadBalancer to the targets. Useful when disableTargetSecurityGroupAssignment=true to manually assign target security groups to targets. (see [below for nested schema](#nestedatt--load_balancer_security_group))
 - `private_address` (String)
-- `status` (String) Enum: "STATUS_UNSPECIFIED" "STATUS_PENDING" "STATUS_READY" "STATUS_ERROR" "STATUS_TERMINATING"
 - `target_security_group` (Attributes) Security Group that allows the targets to receive traffic from the LoadBalancer. Useful when disableTargetSecurityGroupAssignment=true to manually assign target security groups to targets. (see [below for nested schema](#nestedatt--target_security_group))
 - `version` (String) Application Load Balancer resource version. Used for concurrency safe updates.
 
@@ -436,11 +435,19 @@ Optional:
 
 Optional:
 
-- `acl` (Set of String) Use this option to limit the IP ranges that can use the Application Load Balancer.
+- `access_control` (Attributes) Use this option to limit the IP ranges that can use the Application Load Balancer. (see [below for nested schema](#nestedatt--options--access_control))
 - `ephemeral_address` (Boolean) This option automates the handling of the external IP address for an Application Load Balancer. If set to true a new IP address will be automatically created. It will also be automatically deleted when the Load Balancer is deleted.
 - `observability` (Attributes) We offer Load Balancer observability via STACKIT Observability or external solutions. (see [below for nested schema](#nestedatt--options--observability))
 - `private_network_only` (Boolean) Application Load Balancer is accessible only via a private network ip address. Not changeable after creation.
 
+<a id="nestedatt--options--access_control"></a>
+### Nested Schema for `options.access_control`
+
+Required:
+
+- `allowed_source_ranges` (Set of String) Application Load Balancer is accessible only from an IP address in this range.
+
+
 <a id="nestedatt--options--observability"></a>
 ### Nested Schema for `options.observability`
 
@@ -475,7 +482,7 @@ Required:
 Read-Only:
 
 - `description` (String) The error description contains additional helpful user information to fix the error state of the Application Load Balancer. For example the IP 45.135.247.139 does not exist in the project, then the description will report: Floating IP "45.135.247.139" could not be found.
-- `type` (String) Enum: "TYPE_UNSPECIFIED" "TYPE_INTERNAL" "TYPE_QUOTA_SECGROUP_EXCEEDED" "TYPE_QUOTA_SECGROUPRULE_EXCEEDED" "TYPE_PORT_NOT_CONFIGURED" "TYPE_FIP_NOT_CONFIGURED" "TYPE_TARGET_NOT_ACTIVE" "TYPE_METRICS_MISCONFIGURED" "TYPE_LOGS_MISCONFIGURED"
+- `type` (String) Enum: Possible values are: `TYPE_UNSPECIFIED`, `TYPE_INTERNAL`, `TYPE_QUOTA_SECGROUP_EXCEEDED`, `TYPE_QUOTA_SECGROUPRULE_EXCEEDED`, `TYPE_PORT_NOT_CONFIGURED`, `TYPE_FIP_NOT_CONFIGURED`, `TYPE_TARGET_NOT_ACTIVE`, `TYPE_METRICS_MISCONFIGURED`, `TYPE_LOGS_MISCONFIGURED`.
 The error type specifies which part of the Application Load Balancer encountered the error. I.e. the API will not check if a provided public IP is actually available in the project. Instead the Application Load Balancer with try to use the provided IP and if not available reports TYPE_FIP_NOT_CONFIGURED error.
 
 

…/data-sources/stackit_alb/data-source.tf …application_load_balancer/data-source.tfexamples/data-sources/stackit_alb/data-source.tf renamed to examples/data-sources/stackit_application_load_balancer/data-source.tf examples/data-sources/stackit_alb/data-source.tf renamed to examples/data-sources/stackit_application_load_balancer/data-source.tf

@@ -1,4 +1,4 @@
-data "stackit_alb" "example" {
+data "stackit_application_load_balancer" "example" {
   project_id = "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
   name       = "example-load-balancer"
 }

…amples/resources/stackit_alb/resource.tf …it_application_load_balancer/resource.tfexamples/resources/stackit_alb/resource.tf renamed to examples/resources/stackit_application_load_balancer/resource.tf examples/resources/stackit_alb/resource.tf renamed to examples/resources/stackit_application_load_balancer/resource.tf

@@ -97,7 +97,7 @@ resource "stackit_loadbalancer_observability_credential" "observability" {
 }
 
 # Create a Application Load Balancer
-resource "stackit_alb" "example" {
+resource "stackit_application_load_balancer" "example" {
   project_id = var.project_id
   region     = "eu01"
   name       = "example-load-balancer"

stackit/internal/core/core.go

@@ -31,13 +31,13 @@ type ProviderData struct {
 	// Deprecated: Use DefaultRegion instead
 	Region                          string
 	DefaultRegion                   string
+	ALBCustomEndpoint               string
 	AuthorizationCustomEndpoint     string
 	CdnCustomEndpoint               string
 	DnsCustomEndpoint               string
 	GitCustomEndpoint               string
 	IaaSCustomEndpoint              string
 	KMSCustomEndpoint               string
-	ALBCustomEndpoint               string
 	LoadBalancerCustomEndpoint      string
 	LogMeCustomEndpoint             string
 	MariaDBCustomEndpoint           string