Fix empty check for allowed url domain (#455)

GokceGK · web-flow · commit f9f6382030cb · 2024-08-22T09:39:46.000+02:00
diff --git a/internal/cmd/config/set/set.go b/internal/cmd/config/set/set.go
@@ -234,8 +234,9 @@ func parseInput(p *print.Printer, cmd *cobra.Command) (*inputModel, error) {
 		projectIdSet = true
 	}
 
-	allowedUrlDomainFromFlag := flags.FlagToStringValue(p, cmd, allowedUrlDomainFlag)
-	if allowedUrlDomainFromFlag == "" {
+	allowedUrlDomainFromFlag := flags.FlagToStringPointer(p, cmd, allowedUrlDomainFlag)
+	allowedUrlDomainFlagValue := flags.FlagToStringValue(p, cmd, allowedUrlDomainFlag)
+	if allowedUrlDomainFromFlag != nil && allowedUrlDomainFlagValue == "" {
 		p.Warn("The allowed URL domain is set to empty. All URLs will be accepted regardless of their domain.\n")
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -234,8 +234,9 @@ func parseInput(p print.Printer, cmd cobra.Command) (*inputModel, error) {`
`234`	`234`	`projectIdSet = true`
`235`	`235`	`}`
`236`	`236`
`237`		`- allowedUrlDomainFromFlag := flags.FlagToStringValue(p, cmd, allowedUrlDomainFlag)`
`238`		`- if allowedUrlDomainFromFlag == "" {`
	`237`	`+ allowedUrlDomainFromFlag := flags.FlagToStringPointer(p, cmd, allowedUrlDomainFlag)`
	`238`	`+ allowedUrlDomainFlagValue := flags.FlagToStringValue(p, cmd, allowedUrlDomainFlag)`
	`239`	`+ if allowedUrlDomainFromFlag != nil && allowedUrlDomainFlagValue == "" {`
`239`	`240`	`p.Warn("The allowed URL domain is set to empty. All URLs will be accepted regardless of their domain.\n")`
`240`	`241`	`}`
`241`	`242`