Skip to content

Commit f181a7a

Browse files
GokceGKGokceGK
committed
changes in commands to edit descriptions and avoid nil pointer exceptions
1 parent f9a3ee9 commit f181a7a

File tree

9 files changed

+32
-24
lines changed

9 files changed

+32
-24
lines changed

‎docs/stackit_beta_public-ip.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ stackit beta public-ip [flags]
2929
### SEE ALSO
3030

3131
* [stackit beta](./stackit_beta.md) - Contains beta STACKIT CLI commands
32-
* [stackit beta public-ip associate](./stackit_beta_public-ip_associate.md) - Associates a public IP with a network interface or a virtual IP
32+
* [stackit beta public-ip associate](./stackit_beta_public-ip_associate.md) - Associates a Public IP with a network interface or a virtual IP
3333
* [stackit beta public-ip create](./stackit_beta_public-ip_create.md) - Creates a Public IP
3434
* [stackit beta public-ip delete](./stackit_beta_public-ip_delete.md) - Deletes a Public IP
35-
* [stackit beta public-ip describe](./stackit_beta_public-ip_describe.md) - Shows details of a public IP
36-
* [stackit beta public-ip disassociate](./stackit_beta_public-ip_disassociate.md) - Disassociates a public IP from a network interface or a virtual IP
37-
* [stackit beta public-ip list](./stackit_beta_public-ip_list.md) - Lists all public IPs of a project
35+
* [stackit beta public-ip describe](./stackit_beta_public-ip_describe.md) - Shows details of a Public IP
36+
* [stackit beta public-ip disassociate](./stackit_beta_public-ip_disassociate.md) - Disassociates a Public IP from a network interface or a virtual IP
37+
* [stackit beta public-ip list](./stackit_beta_public-ip_list.md) - Lists all Public IPs of a project
3838
* [stackit beta public-ip update](./stackit_beta_public-ip_update.md) - Updates a Public IP
3939

‎docs/stackit_beta_public-ip_associate.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
## stackit beta public-ip associate
22

3-
Associates a public IP with a network interface or a virtual IP
3+
Associates a Public IP with a network interface or a virtual IP
44

55
### Synopsis
66

7-
Associates a public IP with a network interface or a virtual IP.
7+
Associates a Public IP with a network interface or a virtual IP.
88

99
```
1010
stackit beta public-ip associate [flags]

‎docs/stackit_beta_public-ip_describe.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
## stackit beta public-ip describe
22

3-
Shows details of a public IP
3+
Shows details of a Public IP
44

55
### Synopsis
66

7-
Shows details of a public IP.
7+
Shows details of a Public IP.
88

99
```
1010
stackit beta public-ip describe [flags]

‎docs/stackit_beta_public-ip_disassociate.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
## stackit beta public-ip disassociate
22

3-
Disassociates a public IP from a network interface or a virtual IP
3+
Disassociates a Public IP from a network interface or a virtual IP
44

55
### Synopsis
66

7-
Disassociates a public IP from a network interface or a virtual IP.
7+
Disassociates a Public IP from a network interface or a virtual IP.
88

99
```
1010
stackit beta public-ip disassociate [flags]

‎docs/stackit_beta_public-ip_list.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
## stackit beta public-ip list
22

3-
Lists all public IPs of a project
3+
Lists all Public IPs of a project
44

55
### Synopsis
66

7-
Lists all public IPs of a project.
7+
Lists all Public IPs of a project.
88

99
```
1010
stackit beta public-ip list [flags]

‎internal/cmd/beta/public-ip/associate/associate.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ type inputModel struct {
3333
func NewCmd(p *print.Printer) *cobra.Command {
3434
cmd := &cobra.Command{
3535
Use: "associate",
36-
Short: "Associates a public IP with a network interface or a virtual IP",
37-
Long: "Associates a public IP with a network interface or a virtual IP.",
36+
Short: "Associates a Public IP with a network interface or a virtual IP",
37+
Long: "Associates a Public IP with a network interface or a virtual IP.",
3838
Args: args.SingleArg(publicIpIdArg, utils.ValidateUUID),
3939
Example: examples.Build(
4040
examples.NewExample(
@@ -62,7 +62,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
6262
}
6363

6464
if !model.AssumeYes {
65-
prompt := fmt.Sprintf("Are you sure you want to associate public IP %q with resource %v?", publicIpLabel, model.AssociatedResourceId)
65+
prompt := fmt.Sprintf("Are you sure you want to associate public IP %q with resource %v?", publicIpLabel, *model.AssociatedResourceId)
6666
err = p.PromptForConfirmation(prompt)
6767
if err != nil {
6868
return err

‎internal/cmd/beta/public-ip/describe/describe.go‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ type inputModel struct {
3333
func NewCmd(p *print.Printer) *cobra.Command {
3434
cmd := &cobra.Command{
3535
Use: "describe",
36-
Short: "Shows details of a public IP",
37-
Long: "Shows details of a public IP.",
36+
Short: "Shows details of a Public IP",
37+
Long: "Shows details of a Public IP.",
3838
Args: args.SingleArg(publicIpIdArg, utils.ValidateUUID),
3939
Example: examples.Build(
4040
examples.NewExample(
@@ -125,8 +125,12 @@ func outputResult(p *print.Printer, outputFormat string, publicIp *iaas.PublicIp
125125
table.AddSeparator()
126126
table.AddRow("IP ADDRESS", *publicIp.Ip)
127127
table.AddSeparator()
128-
table.AddRow("ASSOCIATED TO", *publicIp.NetworkInterface)
129-
table.AddSeparator()
128+
129+
if publicIp.NetworkInterface != nil {
130+
networkInterfaceId := *publicIp.GetNetworkInterface()
131+
table.AddRow("ASSOCIATED TO", networkInterfaceId)
132+
table.AddSeparator()
133+
}
130134

131135
if publicIp.Labels != nil && len(*publicIp.Labels) > 0 {
132136
labels := []string{}

‎internal/cmd/beta/public-ip/disassociate/disassociate.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ type inputModel struct {
2929
func NewCmd(p *print.Printer) *cobra.Command {
3030
cmd := &cobra.Command{
3131
Use: "disassociate",
32-
Short: "Disassociates a public IP from a network interface or a virtual IP",
33-
Long: "Disassociates a public IP from a network interface or a virtual IP.",
32+
Short: "Disassociates a Public IP from a network interface or a virtual IP",
33+
Long: "Disassociates a Public IP from a network interface or a virtual IP.",
3434
Args: args.SingleArg(publicIpIdArg, utils.ValidateUUID),
3535
Example: examples.Build(
3636
examples.NewExample(

‎internal/cmd/beta/public-ip/list/list.go‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ type inputModel struct {
3434
func NewCmd(p *print.Printer) *cobra.Command {
3535
cmd := &cobra.Command{
3636
Use: "list",
37-
Short: "Lists all public IPs of a project",
38-
Long: "Lists all public IPs of a project.",
37+
Short: "Lists all Public IPs of a project",
38+
Long: "Lists all Public IPs of a project.",
3939
Args: args.NoArgs,
4040
Example: examples.Build(
4141
examples.NewExample(
@@ -167,7 +167,11 @@ func outputResult(p *print.Printer, outputFormat string, publicIps []iaas.Public
167167
table.SetHeader("ID", "IP ADDRESS", "USED BY")
168168

169169
for _, publicIp := range publicIps {
170-
table.AddRow(*publicIp.Id, *publicIp.Ip, *publicIp.NetworkInterface)
170+
networkInterfaceId := ""
171+
if publicIp.NetworkInterface != nil {
172+
networkInterfaceId = *publicIp.GetNetworkInterface()
173+
}
174+
table.AddRow(*publicIp.Id, *publicIp.Ip, networkInterfaceId)
171175
table.AddSeparator()
172176
}
173177

0 commit comments

Comments
 (0)