feature: fixed parsing of global flags

Author: bahkauv70

internal/cmd/beta/security-group/create/create.go

@@ -46,7 +46,6 @@ func NewCmd(p *print.Printer) *cobra.Command {
 }
 
 func configureFlags(cmd *cobra.Command) {
-	globalflags.Configure(cmd.Flags())
 	cmd.Flags().String("name", "", "the name of the security group. Must be <= 63 chars")
 	cmd.Flags().String("description", "", "an optional description of the security group. Must be <= 127 chars")
 	cmd.Flags().Bool("stateful", false, "create a stateful or a stateless security group")

internal/cmd/beta/security-group/create/create_test.go

@@ -188,6 +188,9 @@ func TestParseInput(t *testing.T) {
 		t.Run(tt.description, func(t *testing.T) {
 			p := print.NewPrinter()
 			cmd := NewCmd(p)
+			if err := globalflags.Configure(cmd.Flags()); err != nil {
+				t.Errorf("cannot configure global flags: %v", err)
+			}
 
 			for flag, value := range tt.flagValues {
 				err := cmd.Flags().Set(flag, value)

internal/cmd/beta/security-group/describe/describe.go

@@ -39,7 +39,6 @@ func NewCmd(p *print.Printer) *cobra.Command {
 			return executeDescribe(cmd, p, args)
 		},
 	}
-	configureFlags(cmd)
 
 	return cmd
 }
@@ -74,10 +73,6 @@ func executeDescribe(cmd *cobra.Command, p *print.Printer, args []string) error
 	return nil
 }
 
-func configureFlags(cmd *cobra.Command) {
-	globalflags.Configure(cmd.Flags())
-}
-
 func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APIClient) iaas.ApiGetSecurityGroupRequest {
 	request := apiClient.GetSecurityGroup(ctx, model.ProjectId, model.SecurityGroupId)
 	return request

internal/cmd/beta/security-group/describe/describe_test.go

@@ -121,7 +121,9 @@ func TestParseInput(t *testing.T) {
 		t.Run(tt.description, func(t *testing.T) {
 			p := print.NewPrinter()
 			cmd := NewCmd(p)
-
+			if err := globalflags.Configure(cmd.Flags()); err != nil {
+				t.Errorf("cannot configure global flags: %v", err)
+			}
 			for flag, value := range tt.flagValues {
 				err := cmd.Flags().Set(flag, value)
 				if err != nil {

internal/cmd/beta/security-group/list/list.go

@@ -45,7 +45,6 @@ func NewCmd(p *print.Printer) *cobra.Command {
 }
 
 func configureFlags(cmd *cobra.Command) {
-	globalflags.Configure(cmd.Flags())
 	cmd.Flags().String("labels", "", "a list of labels in the form <key>=<value>")
 }
 

internal/cmd/beta/security-group/list/list_test.go

@@ -121,6 +121,9 @@ func TestParseInput(t *testing.T) {
 		t.Run(tt.description, func(t *testing.T) {
 			p := print.NewPrinter()
 			cmd := NewCmd(p)
+			if err := globalflags.Configure(cmd.Flags()); err != nil {
+				t.Errorf("cannot configure global flags: %v", err)
+			}
 
 			for flag, value := range tt.flagValues {
 				err := cmd.Flags().Set(flag, value)

internal/cmd/beta/security-group/update/update.go

@@ -48,7 +48,6 @@ func NewCmd(p *print.Printer) *cobra.Command {
 }
 
 func configureFlags(cmd *cobra.Command) {
-	globalflags.Configure(cmd.Flags())
 	cmd.Flags().String("name", "", "the name of the security group. Must be <= 63 chars")
 	cmd.Flags().String("description", "", "an optional description of the security group. Must be <= 127 chars")
 	cmd.Flags().StringSlice("labels", nil, "a list of labels in the form <key>=<value>")

internal/cmd/beta/security-group/update/update_test.go

@@ -226,7 +226,9 @@ func TestParseInput(t *testing.T) {
 		t.Run(tt.description, func(t *testing.T) {
 			p := print.NewPrinter()
 			cmd := NewCmd(p)
-
+			if err := globalflags.Configure(cmd.Flags()); err != nil {
+				t.Errorf("cannot configure global flags: %v", err)
+			}
 			for flag, value := range tt.flagValues {
 
 				if err := cmd.Flags().Set(flag, value); err != nil {