Added the 'nil response' test case for the outputResult()

Author: Jan Sternagel

internal/cmd/beta/kms/key/delete/delete_test.go

@@ -255,6 +255,11 @@ func TestOutputResult(t *testing.T) {
 		outputFormat string
 		resp         *kms.Key
 	}{
+		{
+			description: "nil response",
+			resp:        nil,
+			wantErr:     true,
+		},
 		{
 			description: "default output",
 			resp:        &kms.Key{},

internal/cmd/beta/kms/key/list/list.go

@@ -106,6 +106,10 @@ func configureFlags(cmd *cobra.Command) {
 }
 
 func outputResult(p *print.Printer, outputFormat, projectId, keyRingId string, keys []kms.Key) error {
+	if keys == nil {
+		return fmt.Errorf("response was an empty list")
+	}
+
 	switch outputFormat {
 	case print.JSONOutputFormat:
 		details, err := json.MarshalIndent(keys, "", "  ")

internal/cmd/beta/kms/key/list/list_test.go

@@ -206,8 +206,13 @@ func TestOutputResult(t *testing.T) {
 		outputFormat string
 		wantErr      bool
 	}{
-		// Response check was moved inside NewCmd() for better error feedback.
-		// Thus, no check for 'keys = nil' needed
+		{
+			description: "nil response",
+			keys:        nil,
+			projectId:   uuid.NewString(),
+			keyRingId:   uuid.NewString(),
+			wantErr:     true,
+		},
 		{
 			description: "default output",
 			keys:        []kms.Key{},

internal/cmd/beta/kms/key/restore/restore_test.go

@@ -255,6 +255,11 @@ func TestOutputResult(t *testing.T) {
 		outputFormat string
 		resp         *kms.Key
 	}{
+		{
+			description: "nil response",
+			resp:        nil,
+			wantErr:     true,
+		},
 		{
 			description: "default output",
 			resp:        &kms.Key{},

internal/cmd/beta/kms/keyring/delete/delete_test.go

@@ -218,6 +218,11 @@ func TestOutputResult(t *testing.T) {
 		outputFormat string
 		resp         *kms.KeyRing
 	}{
+		{
+			description: "nil response",
+			resp:        nil,
+			wantErr:     true,
+		},
 		{
 			description: "default output",
 			resp:        &kms.KeyRing{},

internal/cmd/beta/kms/keyring/list/list.go

@@ -92,6 +92,10 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *kms.APIClie
 }
 
 func outputResult(p *print.Printer, outputFormat, projectId string, keyRings []kms.KeyRing) error {
+	if keyRings == nil {
+		return fmt.Errorf("response was nil")
+	}
+
 	switch outputFormat {
 	case print.JSONOutputFormat:
 		details, err := json.MarshalIndent(keyRings, "", "  ")

internal/cmd/beta/kms/keyring/list/list_test.go

@@ -179,6 +179,13 @@ func TestOutputResult(t *testing.T) {
 		projectLabel string
 		wantErr      bool
 	}{
+		{
+			description:  "nil response",
+			keyRings:     nil,
+			projectId:    uuid.NewString(),
+			projectLabel: "my-project",
+			wantErr:      true,
+		},
 		{
 			description:  "default output",
 			projectId:    uuid.NewString(),

internal/cmd/beta/kms/version/destroy/destroy_test.go

@@ -283,6 +283,11 @@ func TestOutputResult(t *testing.T) {
 		outputFormat string
 		resp         *kms.Version
 	}{
+		{
+			description: "nil response",
+			resp:        nil,
+			wantErr:     true,
+		},
 		{
 			description: "default output",
 			resp:        &kms.Version{},

internal/cmd/beta/kms/version/disable/disable_test.go

@@ -283,6 +283,11 @@ func TestOutputResult(t *testing.T) {
 		outputFormat string
 		resp         *kms.Version
 	}{
+		{
+			description: "nil response",
+			resp:        nil,
+			wantErr:     true,
+		},
 		{
 			description: "default output",
 			resp:        &kms.Version{},

internal/cmd/beta/kms/version/enable/enable_test.go

@@ -283,6 +283,11 @@ func TestOutputResult(t *testing.T) {
 		outputFormat string
 		resp         *kms.Version
 	}{
+		{
+			description: "nil response",
+			resp:        nil,
+			wantErr:     true,
+		},
 		{
 			description: "default output",
 			resp:        &kms.Version{},