feature: refactored tests to reused actual cobra command

Author: bahkauv70

internal/cmd/beta/security-group/create/create_test.go

@@ -12,7 +12,6 @@ import (
 	"github.com/google/go-cmp/cmp"
 	"github.com/google/go-cmp/cmp/cmpopts"
 	"github.com/google/uuid"
-	"github.com/spf13/cobra"
 	"github.com/stackitcloud/stackit-sdk-go/services/iaas"
 )
 
@@ -65,11 +64,11 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
 func fixtureRequest(mods ...func(request *iaas.ApiCreateSecurityGroupRequest)) iaas.ApiCreateSecurityGroupRequest {
 	request := testClient.CreateSecurityGroup(testCtx, testProjectId)
 	request = request.CreateSecurityGroupPayload(iaas.CreateSecurityGroupPayload{
-		Description: utils.Ptr(testDescription),
+		Description: &testDescription,
 		Labels:      &testLabels,
-		Name:        utils.Ptr(testName),
+		Name:        &testName,
 		Rules:       nil,
-		Stateful:    utils.Ptr(testStateful),
+		Stateful:    &testStateful,
 	})
 	for _, mod := range mods {
 		mod(&request)
@@ -187,12 +186,8 @@ func TestParseInput(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.description, func(t *testing.T) {
-			cmd := &cobra.Command{}
-			configureFlags(cmd)
-			err := globalflags.Configure(cmd.Flags())
-			if err != nil {
-				t.Fatalf("configure global flags: %v", err)
-			}
+			p := print.NewPrinter()
+			cmd := NewCmd(p)
 
 			for flag, value := range tt.flagValues {
 				err := cmd.Flags().Set(flag, value)
@@ -204,15 +199,13 @@ func TestParseInput(t *testing.T) {
 				}
 			}
 
-			err = cmd.ValidateRequiredFlags()
-			if err != nil {
+			if err := cmd.ValidateRequiredFlags(); err != nil {
 				if !tt.isValid {
 					return
 				}
 				t.Fatalf("error validating flags: %v", err)
 			}
 
-			p := print.NewPrinter()
 			model, err := parseInput(p, cmd)
 			if err != nil {
 				if !tt.isValid {

internal/cmd/beta/security-group/delete/delete_test.go

@@ -10,7 +10,6 @@ import (
 	"github.com/google/go-cmp/cmp"
 	"github.com/google/go-cmp/cmp/cmpopts"
 	"github.com/google/uuid"
-	"github.com/spf13/cobra"
 	"github.com/stackitcloud/stackit-sdk-go/services/iaas"
 )
 
@@ -95,11 +94,18 @@ func TestParseInput(t *testing.T) {
 			args: []string{"foo","bar"},
 			isValid: false,
 		},
+		{
+			description: "invalid group id",
+			flagValues: fixtureFlagValues(),
+			args: []string{"foo"},
+			isValid: false,
+		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.description, func(t *testing.T) {
-			cmd := &cobra.Command{}
+			p := print.NewPrinter()
+			cmd:=NewCmd(p)
 			err := globalflags.Configure(cmd.Flags())
 			if err != nil {
 				t.Fatalf("configure global flags: %v", err)
@@ -124,7 +130,6 @@ func TestParseInput(t *testing.T) {
 				t.Fatalf("error validating flags: %v", err)
 			}
 
-			p := print.NewPrinter()
 			model, err := parseInput(p, cmd, tt.args)
 			if err != nil {
 				if !tt.isValid {

internal/cmd/beta/security-group/list/list_test.go

@@ -10,7 +10,6 @@ import (
 	"github.com/google/go-cmp/cmp"
 	"github.com/google/go-cmp/cmp/cmpopts"
 	"github.com/google/uuid"
-	"github.com/spf13/cobra"
 	"github.com/stackitcloud/stackit-sdk-go/services/iaas"
 )
 
@@ -120,12 +119,8 @@ func TestParseInput(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.description, func(t *testing.T) {
-			cmd := &cobra.Command{}
-			configureFlags(cmd)
-			err := globalflags.Configure(cmd.Flags())
-			if err != nil {
-				t.Fatalf("configure global flags: %v", err)
-			}
+			p := print.NewPrinter()
+			cmd := NewCmd(p)
 
 			for flag, value := range tt.flagValues {
 				err := cmd.Flags().Set(flag, value)
@@ -137,15 +132,13 @@ func TestParseInput(t *testing.T) {
 				}
 			}
 
-			err = cmd.ValidateRequiredFlags()
-			if err != nil {
+			if err := cmd.ValidateRequiredFlags(); err != nil {
 				if !tt.isValid {
 					return
 				}
 				t.Fatalf("error validating flags: %v", err)
 			}
 
-			p := print.NewPrinter()
 			model, err := parseInput(p, cmd)
 			if err != nil {
 				if !tt.isValid {