Skip to content

Commit 5bb1627

Browse files
committed
Add checks if serverLabel is empty
1 parent 72b451d commit 5bb1627

File tree

38 files changed

+100
-17
lines changed

38 files changed

+100
-17
lines changed

internal/cmd/beta/server/backup/create/create.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
7373
serverName, err := iaasUtils.GetServerName(ctx, iaasApiClient, model.ProjectId, model.ServerId)
7474
if err != nil {
7575
p.Debug(print.ErrorLevel, "get server name: %v", err)
76-
} else {
76+
} else if serverName != "" {
7777
serverLabel = serverName
7878
}
7979
}

internal/cmd/beta/server/backup/disable/disable.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
5858
serverName, err := iaasUtils.GetServerName(ctx, iaasApiClient, model.ProjectId, model.ServerId)
5959
if err != nil {
6060
p.Debug(print.ErrorLevel, "get server name: %v", err)
61-
} else {
61+
} else if serverName != "" {
6262
serverLabel = serverName
6363
}
6464
}

internal/cmd/beta/server/backup/enable/enable.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
5858
serverName, err := iaasUtils.GetServerName(ctx, iaasApiClient, model.ProjectId, model.ServerId)
5959
if err != nil {
6060
p.Debug(print.ErrorLevel, "get server name: %v", err)
61-
} else {
61+
} else if serverName != "" {
6262
serverLabel = serverName
6363
}
6464
}

internal/cmd/beta/server/backup/list/list.go

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ import (
1313
"github.com/stackitcloud/stackit-cli/internal/pkg/flags"
1414
"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
1515
"github.com/stackitcloud/stackit-cli/internal/pkg/print"
16+
iaasClient "github.com/stackitcloud/stackit-cli/internal/pkg/services/iaas/client"
17+
iaasUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/iaas/utils"
1618
"github.com/stackitcloud/stackit-cli/internal/pkg/services/serverbackup/client"
1719
"github.com/stackitcloud/stackit-cli/internal/pkg/tables"
1820
"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
@@ -65,7 +67,17 @@ func NewCmd(p *print.Printer) *cobra.Command {
6567
}
6668
backups := *resp.Items
6769
if len(backups) == 0 {
68-
p.Info("No backups found for server %s\n", model.ServerId)
70+
serverLabel := model.ServerId
71+
// Get server name
72+
if iaasApiClient, err := iaasClient.ConfigureClient(p); err == nil {
73+
serverName, err := iaasUtils.GetServerName(ctx, iaasApiClient, model.ProjectId, model.ServerId)
74+
if err != nil {
75+
p.Debug(print.ErrorLevel, "get server name: %v", err)
76+
} else if serverName != "" {
77+
serverLabel = serverName
78+
}
79+
}
80+
p.Info("No backups found for server %s\n", serverLabel)
6981
return nil
7082
}
7183

internal/cmd/beta/server/backup/schedule/create/create.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
8181
serverName, err := iaasUtils.GetServerName(ctx, iaasApiClient, model.ProjectId, model.ServerId)
8282
if err != nil {
8383
p.Debug(print.ErrorLevel, "get server name: %v", err)
84-
} else {
84+
} else if serverName != "" {
8585
serverLabel = serverName
8686
}
8787
}

internal/cmd/beta/server/backup/schedule/delete/delete.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
5959
serverName, err := iaasUtils.GetServerName(ctx, iaasApiClient, model.ProjectId, model.ServerId)
6060
if err != nil {
6161
p.Debug(print.ErrorLevel, "get server name: %v", err)
62-
} else {
62+
} else if serverName != "" {
6363
serverLabel = serverName
6464
}
6565
}

internal/cmd/beta/server/backup/schedule/list/list.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
6565
serverName, err := iaasUtils.GetServerName(ctx, iaasApiClient, model.ProjectId, model.ServerId)
6666
if err != nil {
6767
p.Debug(print.ErrorLevel, "get server name: %v", err)
68-
} else {
68+
} else if serverName != "" {
6969
serverLabel = serverName
7070
}
7171
}

internal/cmd/beta/server/command/create/create.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
6969
serverName, err := iaasUtils.GetServerName(ctx, iaasApiClient, model.ProjectId, model.ServerId)
7070
if err != nil {
7171
p.Debug(print.ErrorLevel, "get server name: %v", err)
72-
} else {
72+
} else if serverName != "" {
7373
serverLabel = serverName
7474
}
7575
}

internal/cmd/beta/server/command/list/list.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ func NewCmd(p *print.Printer) *cobra.Command {
6565
serverName, err := iaasUtils.GetServerName(ctx, iaasApiClient, model.ProjectId, model.ServerId)
6666
if err != nil {
6767
p.Debug(print.ErrorLevel, "get server name: %v", err)
68-
} else {
68+
} else if serverName != "" {
6969
serverLabel = serverName
7070
}
7171
}

internal/cmd/beta/server/console/console.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,9 @@ func NewCmd(p *print.Printer) *cobra.Command {
6363
p.Debug(print.ErrorLevel, "get server name: %v", err)
6464
serverLabel = model.ServerId
6565
}
66+
if serverLabel == "" {
67+
serverLabel = model.ServerId
68+
}
6669

6770
// Call API
6871
req := buildRequest(ctx, model, apiClient)

0 commit comments

Comments
 (0)