Skip to content

Commit 5a7af4f

Browse files
author
Jan Sternagel
committed
cmd config setup
1 parent 7ee923b commit 5a7af4f

File tree

3 files changed

+24
-0
lines changed

3 files changed

+24
-0
lines changed

internal/cmd/config/set/set.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ const (
3737
redisCustomEndpointFlag = "redis-custom-endpoint"
3838
resourceManagerCustomEndpointFlag = "resource-manager-custom-endpoint"
3939
secretsManagerCustomEndpointFlag = "secrets-manager-custom-endpoint"
40+
kmsCustomEndpointFlag = "kms-custom-endpoint"
4041
serverBackupCustomEndpointFlag = "serverbackup-custom-endpoint"
4142
serverOsUpdateCustomEndpointFlag = "server-osupdate-custom-endpoint"
4243
runCommandCustomEndpointFlag = "runcommand-custom-endpoint"
@@ -150,6 +151,7 @@ func configureFlags(cmd *cobra.Command) {
150151
cmd.Flags().String(redisCustomEndpointFlag, "", "Redis API base URL, used in calls to this API")
151152
cmd.Flags().String(resourceManagerCustomEndpointFlag, "", "Resource Manager API base URL, used in calls to this API")
152153
cmd.Flags().String(secretsManagerCustomEndpointFlag, "", "Secrets Manager API base URL, used in calls to this API")
154+
cmd.Flags().String(kmsCustomEndpointFlag, "", "KMS API base URL, used in calls to this API")
153155
cmd.Flags().String(serviceAccountCustomEndpointFlag, "", "Service Account API base URL, used in calls to this API")
154156
cmd.Flags().String(serviceEnablementCustomEndpointFlag, "", "Service Enablement API base URL, used in calls to this API")
155157
cmd.Flags().String(serverBackupCustomEndpointFlag, "", "Server Backup API base URL, used in calls to this API")
@@ -197,6 +199,8 @@ func configureFlags(cmd *cobra.Command) {
197199
cobra.CheckErr(err)
198200
err = viper.BindPFlag(config.SecretsManagerCustomEndpointKey, cmd.Flags().Lookup(secretsManagerCustomEndpointFlag))
199201
cobra.CheckErr(err)
202+
err = viper.BindPFlag(config.KMSCustomEndpointKey, cmd.Flags().Lookup(kmsCustomEndpointFlag))
203+
cobra.CheckErr(err)
200204
err = viper.BindPFlag(config.ServerBackupCustomEndpointKey, cmd.Flags().Lookup(serverBackupCustomEndpointFlag))
201205
cobra.CheckErr(err)
202206
err = viper.BindPFlag(config.ServerOsUpdateCustomEndpointKey, cmd.Flags().Lookup(serverOsUpdateCustomEndpointFlag))

internal/cmd/config/unset/unset.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ const (
4141
redisCustomEndpointFlag = "redis-custom-endpoint"
4242
resourceManagerCustomEndpointFlag = "resource-manager-custom-endpoint"
4343
secretsManagerCustomEndpointFlag = "secrets-manager-custom-endpoint"
44+
kmsCustomEndpointFlag = "kms-custom-endpoint"
4445
serviceAccountCustomEndpointFlag = "service-account-custom-endpoint"
4546
serviceEnablementCustomEndpointFlag = "service-enablement-custom-endpoint"
4647
serverBackupCustomEndpointFlag = "serverbackup-custom-endpoint"
@@ -78,6 +79,7 @@ type inputModel struct {
7879
RedisCustomEndpoint bool
7980
ResourceManagerCustomEndpoint bool
8081
SecretsManagerCustomEndpoint bool
82+
KMSCustomEndpoint bool
8183
ServerBackupCustomEndpoint bool
8284
ServerOsUpdateCustomEndpoint bool
8385
RunCommandCustomEndpoint bool
@@ -180,6 +182,9 @@ func NewCmd(params *params.CmdParams) *cobra.Command {
180182
if model.SecretsManagerCustomEndpoint {
181183
viper.Set(config.SecretsManagerCustomEndpointKey, "")
182184
}
185+
if model.KMSCustomEndpoint {
186+
viper.Set(config.KMSCustomEndpointKey, "")
187+
}
183188
if model.ServiceAccountCustomEndpoint {
184189
viper.Set(config.ServiceAccountCustomEndpointKey, "")
185190
}
@@ -245,6 +250,7 @@ func configureFlags(cmd *cobra.Command) {
245250
cmd.Flags().Bool(redisCustomEndpointFlag, false, "Redis API base URL. If unset, uses the default base URL")
246251
cmd.Flags().Bool(resourceManagerCustomEndpointFlag, false, "Resource Manager API base URL. If unset, uses the default base URL")
247252
cmd.Flags().Bool(secretsManagerCustomEndpointFlag, false, "Secrets Manager API base URL. If unset, uses the default base URL")
253+
cmd.Flags().Bool(kmsCustomEndpointFlag, false, "KMS API base URL. If unset, uses the default base URL")
248254
cmd.Flags().Bool(serviceAccountCustomEndpointFlag, false, "Service Account API base URL. If unset, uses the default base URL")
249255
cmd.Flags().Bool(serviceEnablementCustomEndpointFlag, false, "Service Enablement API base URL. If unset, uses the default base URL")
250256
cmd.Flags().Bool(serverBackupCustomEndpointFlag, false, "Server Backup base URL. If unset, uses the default base URL")
@@ -283,6 +289,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command) *inputModel {
283289
RedisCustomEndpoint: flags.FlagToBoolValue(p, cmd, redisCustomEndpointFlag),
284290
ResourceManagerCustomEndpoint: flags.FlagToBoolValue(p, cmd, resourceManagerCustomEndpointFlag),
285291
SecretsManagerCustomEndpoint: flags.FlagToBoolValue(p, cmd, secretsManagerCustomEndpointFlag),
292+
KMSCustomEndpoint: flags.FlagToBoolValue(p, cmd, kmsCustomEndpointFlag),
286293
ServiceAccountCustomEndpoint: flags.FlagToBoolValue(p, cmd, serviceAccountCustomEndpointFlag),
287294
ServiceEnablementCustomEndpoint: flags.FlagToBoolValue(p, cmd, serviceEnablementCustomEndpointFlag),
288295
ServerBackupCustomEndpoint: flags.FlagToBoolValue(p, cmd, serverBackupCustomEndpointFlag),

internal/cmd/config/unset/unset_test.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ func fixtureFlagValues(mods ...func(flagValues map[string]bool)) map[string]bool
3535
redisCustomEndpointFlag: true,
3636
resourceManagerCustomEndpointFlag: true,
3737
secretsManagerCustomEndpointFlag: true,
38+
kmsCustomEndpointFlag: true,
3839
serviceAccountCustomEndpointFlag: true,
3940
serverBackupCustomEndpointFlag: true,
4041
serverOsUpdateCustomEndpointFlag: true,
@@ -74,6 +75,7 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
7475
RedisCustomEndpoint: true,
7576
ResourceManagerCustomEndpoint: true,
7677
SecretsManagerCustomEndpoint: true,
78+
KMSCustomEndpoint: true,
7779
ServiceAccountCustomEndpoint: true,
7880
ServerBackupCustomEndpoint: true,
7981
ServerOsUpdateCustomEndpoint: true,
@@ -129,6 +131,7 @@ func TestParseInput(t *testing.T) {
129131
model.RedisCustomEndpoint = false
130132
model.ResourceManagerCustomEndpoint = false
131133
model.SecretsManagerCustomEndpoint = false
134+
model.KMSCustomEndpoint = false
132135
model.ServiceAccountCustomEndpoint = false
133136
model.ServerBackupCustomEndpoint = false
134137
model.ServerOsUpdateCustomEndpoint = false
@@ -219,6 +222,16 @@ func TestParseInput(t *testing.T) {
219222
model.SecretsManagerCustomEndpoint = false
220223
}),
221224
},
225+
{
226+
description: "kms custom endpoint empty",
227+
flagValues: fixtureFlagValues(func(flagValues map[string]bool) {
228+
flagValues[kmsCustomEndpointFlag] = false
229+
}),
230+
isValid: true,
231+
expectedModel: fixtureInputModel(func(model *inputModel) {
232+
model.KMSCustomEndpoint = false
233+
}),
234+
},
222235
{
223236
description: "service account custom endpoint empty",
224237
flagValues: fixtureFlagValues(func(flagValues map[string]bool) {

0 commit comments

Comments
 (0)