fix possible nil pointer issue // extend unit tests

Author: GokceGK

internal/pkg/services/logs/utils/utils.go

@@ -2,11 +2,17 @@ package utils
 
 import (
 	"context"
+	"errors"
 	"fmt"
 
 	"github.com/stackitcloud/stackit-sdk-go/services/logs"
 )
 
+var (
+	ErrResponseNil = errors.New("response is nil")
+	ErrNameNil     = errors.New("display name is nil")
+)
+
 type LogsClient interface {
 	GetLogsInstanceExecute(ctx context.Context, projectId, regionId, instanceId string) (*logs.LogsInstance, error)
 }
@@ -15,6 +21,10 @@ func GetInstanceName(ctx context.Context, apiClient LogsClient, projectId, regio
 	resp, err := apiClient.GetLogsInstanceExecute(ctx, projectId, regionId, instanceId)
 	if err != nil {
 		return "", fmt.Errorf("get Logs instance: %w", err)
+	} else if resp == nil {
+		return "", ErrResponseNil
+	} else if resp.DisplayName == nil {
+		return "", ErrNameNil
 	}
 	return *resp.DisplayName, nil
 }

internal/pkg/services/logs/utils/utils_test.go

@@ -54,6 +54,20 @@ func TestGetInstanceName(t *testing.T) {
 			getInstanceFails: true,
 			isValid:          false,
 		},
+		{
+			description:      "response is nil",
+			getInstanceFails: false,
+			getInstanceResp:  nil,
+			isValid:          false,
+		},
+		{
+			description:      "name in response is nil",
+			getInstanceFails: false,
+			getInstanceResp: &logs.LogsInstance{
+				DisplayName: nil,
+			},
+			isValid: false,
+		},
 	}
 
 	for _, tt := range tests {