Address review: move some vars into constants in tests

Author: Yago Carlos Fernandez Gou

internal/cmd/intake/runner/create/create_test.go

@@ -17,21 +17,23 @@ import (
 // Define a unique key for the context to avoid collisions
 type testCtxKey struct{}
 
+const (
+	testRegion             = "eu01"
+	testDisplayName        = "testrunner"
+	testMaxMessageSizeKiB  = int64(1024)
+	testMaxMessagesPerHour = int64(10000)
+	testDescription        = "This is a test runner"
+	testLabelsString       = "env=test,team=dev"
+)
+
 var (
 	// testCtx dummy context for testing purposes
 	testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
 	// testClient mock API client
 	testClient    = &intake.APIClient{}
 	testProjectId = uuid.NewString()
-	testRegion    = "eu01"
 
-	// Define test values for flags
-	testDisplayName        = "testrunner"
-	testMaxMessageSizeKiB  = int64(1024)
-	testMaxMessagesPerHour = int64(10000)
-	testDescription        = "This is a test runner"
-	testLabels             = map[string]string{"env": "test", "team": "dev"}
-	testLabelsString       = "env=test,team=dev"
+	testLabels = map[string]string{"env": "test", "team": "dev"}
 )
 
 // fixtureFlagValues generates a map of flag values for tests

internal/cmd/intake/runner/delete/delete_test.go

@@ -16,14 +16,17 @@ import (
 // Define a unique key for the context to avoid collisions
 type testCtxKey struct{}
 
+const (
+	testRegion = "eu01"
+)
+
 var (
 	// testCtx is a dummy context for testing purposes
 	testCtx = context.WithValue(context.Background(), testCtxKey{}, "foo")
 	// testClient is a mock API client
 	testClient    = &intake.APIClient{}
 	testProjectId = uuid.NewString()
 	testRunnerId  = uuid.NewString()
-	testRegion    = "eu01"
 )
 
 // fixtureArgValues generates a slice of arguments for tests

internal/cmd/intake/runner/describe/describe_test.go

@@ -15,12 +15,15 @@ import (
 
 type testCtxKey struct{}
 
+const (
+	testRegion = "eu01"
+)
+
 var (
 	testCtx       = context.WithValue(context.Background(), testCtxKey{}, "foo")
 	testClient    = &intake.APIClient{}
 	testProjectId = uuid.NewString()
 	testRunnerId  = uuid.NewString()
-	testRegion    = "eu01"
 )
 
 func fixtureArgValues(mods ...func(argValues []string)) []string {

internal/cmd/intake/runner/list/list_test.go

@@ -17,12 +17,15 @@ import (
 
 type testCtxKey struct{}
 
+const (
+	testRegion = "eu01"
+	testLimit  = int64(5)
+)
+
 var (
 	testCtx       = context.WithValue(context.Background(), testCtxKey{}, "foo")
 	testClient    = &intake.APIClient{}
 	testProjectId = uuid.NewString()
-	testRegion    = "eu01"
-	testLimit     = int64(5)
 )
 
 func fixtureFlagValues(mods ...func(flagValues map[string]string)) map[string]string {

internal/cmd/intake/runner/update/update_test.go

@@ -16,12 +16,15 @@ import (
 
 type testCtxKey struct{}
 
+const (
+	testRegion = "eu01"
+)
+
 var (
 	testCtx       = context.WithValue(context.Background(), testCtxKey{}, "foo")
 	testClient    = &intake.APIClient{}
 	testProjectId = uuid.NewString()
 	testRunnerId  = uuid.NewString()
-	testRegion    = "eu01"
 )
 
 func fixtureArgValues(mods ...func(argValues []string)) []string {