Skip to content

Commit 056ffdb

Browse files
author
Jan Sternagel
committed
remove comments
1 parent d5545f7 commit 056ffdb

File tree

3 files changed

+0
-6
lines changed

3 files changed

+0
-6
lines changed

internal/cmd/beta/kms/key/create/create.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,6 @@ func parseInput(p *print.Printer, cmd *cobra.Command) (*inputModel, error) {
120120
return nil, &cliErr.ProjectIdError{}
121121
}
122122

123-
// What checks could this need?
124-
// I would rather let the creation fail instead of checking all possible algorithms
125123
model := inputModel{
126124
GlobalFlagModel: globalFlags,
127125
KeyRingId: flags.FlagToStringValue(p, cmd, keyRingIdFlag),
@@ -151,7 +149,6 @@ type kmsKeyClient interface {
151149
func buildRequest(ctx context.Context, model *inputModel, apiClient kmsKeyClient) (kms.ApiCreateKeyRequest, error) {
152150
req := apiClient.CreateKey(ctx, model.ProjectId, model.Region, model.KeyRingId)
153151

154-
// Question: Should there be additional checks here?
155152
req = req.CreateKeyPayload(kms.CreateKeyPayload{
156153
DisplayName: model.Name,
157154
Description: model.Description,

internal/cmd/beta/kms/key/importKey/importKey.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ type kmsKeyClient interface {
142142
func buildRequest(ctx context.Context, model *inputModel, apiClient kmsKeyClient) (kms.ApiImportKeyRequest, error) {
143143
req := apiClient.ImportKey(ctx, model.ProjectId, model.Region, model.KeyRingId, model.KeyId)
144144

145-
// Question: Should there be additional checks here?
146145
req = req.ImportKeyPayload(kms.ImportKeyPayload{
147146
WrappedKey: model.WrappedKey,
148147
WrappingKeyId: model.WrappingKeyId,

internal/cmd/beta/kms/wrappingkey/create/create.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,6 @@ type kmsWrappingKeyClient interface {
147147
func buildRequest(ctx context.Context, model *inputModel, apiClient kmsWrappingKeyClient) (kms.ApiCreateWrappingKeyRequest, error) {
148148
req := apiClient.CreateWrappingKey(ctx, model.ProjectId, model.Region, model.KeyRingId)
149149

150-
// Question: Should there be additional checks here?
151-
152150
req = req.CreateWrappingKeyPayload(kms.CreateWrappingKeyPayload{
153151
DisplayName: model.Name,
154152
Description: model.Description,

0 commit comments

Comments
 (0)