@@ -100,12 +100,12 @@ class HttpMixin(object):
100100 }
101101
102102 def __init__ (self , auth = None , verify = True ):
103- self ._http_options = {}
104- self ._http_options ['auth' ] = auth
105- self ._http_options ['verify' ] = verify
103+ self ._http_options = {
104+ 'auth' : auth ,
105+ 'verify' : verify ,
106+ }
106107 self ._http_log = logging .getLogger (__name__ )
107108
108-
109109 def _request (self , verb , url , quiet = False ,
110110 none_on_404 = False , jsonify = False , raise_for_status = True ,
111111 * args , ** kwargs ):
@@ -114,17 +114,20 @@ def _request(self, verb, url, quiet=False,
114114 self ._http_log .info ("{0}: {1}" .format (verb , url ))
115115
116116 headers = kwargs .get ('headers' , HttpMixin .HEADERS ['json' ])
117+
117118 result = requests .request (verb , url ,
118119 auth = self ._http_options ['auth' ],
119120 headers = headers ,
120121 verify = self ._http_options ['verify' ],
121122 * args , ** kwargs )
122123
123-
124124 # Handle special conditions
125125 if none_on_404 and result .status_code == 404 :
126126 return None
127127
128+ elif result .status_code == 204 :
129+ return None
130+
128131 elif raise_for_status :
129132 try :
130133 result .raise_for_status ()
@@ -138,26 +141,20 @@ def _request(self, verb, url, quiet=False,
138141 else :
139142 return result
140143
141-
142144 def _head (self , url , * args , ** kwargs ):
143145 return self ._request ("HEAD" , url , * args , ** kwargs )
144146
145-
146147 def _get (self , url , * args , ** kwargs ):
147148 return self ._request ("GET" , url , * args , ** kwargs )
148149
149-
150150 def _delete (self , url , * args , ** kwargs ):
151151 return self ._request ("DELETE" , url , * args , ** kwargs )
152152
153-
154153 def _post (self , url , data = None , * args , ** kwargs ):
155154 return self ._request ("POST" , url , data = data , * args , ** kwargs )
156155
157-
158156 def _put (self , url , data = None , * args , ** kwargs ):
159157 return self ._request ("PUT" , url , data = data , * args , ** kwargs )
160158
161-
162159 def _patch (self , url , data = None , * args , ** kwargs ):
163160 return self ._request ("PATCH" , url , data = data , * args , ** kwargs )
0 commit comments