Skip to content

Commit 8af0471

Browse files
committed
added comment and changelog entry
1 parent b9b6100 commit 8af0471

File tree

4 files changed

+20
-13
lines changed

4 files changed

+20
-13
lines changed

extra/completions/_stackablectl

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extra/completions/stackablectl.fish

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rust/stackablectl/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,14 @@ All notable changes to this project will be documented in this file.
77
### Added
88

99
- Add new argument `--release` that allows installing a specific version of a demo or stack ([#340]).
10+
- Add new argument `--chart-source` so that operator charts can be pulled either from an OCI registry (the default) or from a Nexus repository ([#344]).
1011

1112
### Removed
1213

1314
- Remove argument `--offline` that was not implemented yet ([#340]).
1415

1516
[#340]: https://github.com/stackabletech/stackable-cockpit/pull/340
17+
[#344]: https://github.com/stackabletech/stackable-cockpit/pull/344
1618

1719
## [24.11.1] - 2024-11-20
1820

rust/stackablectl/src/cli/mod.rs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,11 +298,16 @@ pub enum ChartSourceTypeArg {
298298
#[default]
299299
OCI,
300300

301-
/// Nexus repositories: resolution (dev, test, stable) is based on the version and thus may be operator-specific
301+
/// Nexus repositories: resolution (dev, test, stable) is based on the version and thus will be operator-specific
302302
Repo,
303303
}
304304

305305
impl From<ChartSourceTypeArg> for ChartSourceType {
306+
/// Resolves the enum used by clap/arg-resolution to the core type used in
307+
/// stackable-cockpit. For the (Nexus-)repo case this core type cannot be
308+
/// decorated with meaningful information as that would be operator-specific
309+
/// i.e. we cannot resolve *which* Nexus repo to use until we have inspected
310+
/// the operator version. Hence just a simple mapping.
306311
fn from(cli_enum: ChartSourceTypeArg) -> Self {
307312
match cli_enum {
308313
ChartSourceTypeArg::OCI => ChartSourceType::OCI,

0 commit comments

Comments
 (0)