Skip to content

Commit 2c72e64

Browse files
committed
chore(instrumentation): Tidy up helm repo list
1 parent cf2c87c commit 2c72e64

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

rust/stackablectl/src/cmds/operator.rs

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,13 @@ fn build_versions_list(
518518

519519
for operator in operator::VALID_OPERATORS {
520520
for (helm_repo_name, helm_repo_index_file) in helm_index_files {
521-
let versions = list_operator_versions_from_repo(operator, helm_repo_index_file)?;
521+
let span = tracing::info_span!(
522+
"build_versions_list_iter",
523+
helm.repository.name = %helm_repo_name,
524+
operator_name = %operator,
525+
);
526+
let versions =
527+
span.in_scope(|| list_operator_versions_from_repo(operator, helm_repo_index_file))?;
522528
let entry = versions_list.entry(operator.to_string());
523529
let entry = entry.or_insert(OperatorVersionList(HashMap::new()));
524530
entry.0.insert(helm_repo_name.to_string(), versions);
@@ -560,15 +566,16 @@ fn list_operator_versions_from_repo<T>(
560566
where
561567
T: AsRef<str> + std::fmt::Display + std::fmt::Debug,
562568
{
563-
debug!("Listing operator versions from repo");
569+
debug!("Listing operator versions from repository");
564570

565-
let operator_name = utils::operator_chart_name(operator_name.as_ref());
571+
let chart_name = utils::operator_chart_name(operator_name.as_ref());
566572

567-
match helm_repo.entries.get(&operator_name) {
573+
match helm_repo.entries.get(&chart_name) {
568574
Some(entries) => {
569575
let mut versions = entries
570576
.iter()
571577
.map(|entry| {
578+
tracing::trace!(helm.chart.name = %chart_name, helm.chart.version = %entry.version, "Found operator chart version");
572579
Version::parse(&entry.version).with_context(|_| InvalidHelmChartVersionSnafu {
573580
version: entry.version.clone(),
574581
})

0 commit comments

Comments
 (0)