remove default impl for Duration

Author: razvan

crates/stackable-operator/src/product_config_utils.rs

@@ -618,7 +618,7 @@ mod tests {
             env_overrides: env_overrides.unwrap_or_default(),
             cli_overrides: cli_overrides.unwrap_or_default(),
             pod_overrides: PodTemplateSpec::default(),
-            min_secret_lifetime: Duration::default(),
+            min_secret_lifetime: Duration::from_secs(0),
         }
     }
 

crates/stackable-operator/src/role_utils.rs

@@ -101,7 +101,7 @@ use kube::{runtime::reflector::ObjectRef, Resource};
 use schemars::JsonSchema;
 use serde::{Deserialize, Serialize};
 
-#[derive(Clone, Debug, Default, Deserialize, JsonSchema, PartialEq, Serialize)]
+#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
 #[serde(
     rename_all = "camelCase",
     bound(deserialize = "T: Default + Deserialize<'de>")
@@ -155,6 +155,22 @@ pub struct CommonConfiguration<T> {
     pub min_secret_lifetime: Duration,
 }
 
+impl<T> Default for CommonConfiguration<T>
+where
+    T: Default,
+{
+    fn default() -> Self {
+        Self {
+            config: T::default(),
+            config_overrides: HashMap::default(),
+            env_overrides: HashMap::default(),
+            cli_overrides: BTreeMap::default(),
+            pod_overrides: PodTemplateSpec::default(),
+            min_secret_lifetime: Duration::from_secs(0),
+        }
+    }
+}
+
 fn default_min_secret_lifetime() -> Duration {
     Duration::from_hours_unchecked(24)
 }

crates/stackable-operator/src/time/duration.rs

@@ -301,14 +301,6 @@ impl Div<u32> for Duration {
     }
 }
 
-/// This implementation is needed for `CommonConfiguration::min_secret_lifetime`.
-/// The default value is arbitrary and should probably not be assumed at call sites.
-impl Default for Duration {
-    fn default() -> Self {
-        Duration::from_hours_unchecked(1)
-    }
-}
-
 impl Duration {
     /// Creates a new [`Duration`] containing the amount of time passed since
     /// 1970-01-01 UTC. This can be used to calculate [`Duration`]s based on