Skip to content

Commit c5145fe

Browse files
razvanadwk67
andauthored
feat: run containerdebug in the background (#666)
* feat: run containerdebug in the background * fix copy&paste * fix pr number * fix test * cargo update * fixed workflow * use branch name not refs --------- Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
1 parent d927036 commit c5145fe

File tree

5 files changed

+613
-276
lines changed

5 files changed

+613
-276
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -345,11 +345,11 @@ jobs:
345345
crate: cargo-edit
346346
bin: cargo-set-version
347347
- name: Update version if PR against main branch
348-
if: ${{ github.event_name == 'pull_request' && github.ref == 'refs/heads/main' }}
348+
if: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'main' }}
349349
run: cargo set-version --offline --workspace 0.0.0-pr${{ github.event.pull_request.number }}
350350
- name: Update version if PR against non-main branch
351351
# For PRs to be merged against a release branch, use the version that has already been set in the calling script.
352-
if: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/main' }}
352+
if: ${{ github.event_name == 'pull_request' && startsWith(github.event.pull_request.base.ref, 'release-') }}
353353
env:
354354
PR_NUMBER: ${{ github.event.pull_request.number }}
355355
run: |
@@ -420,11 +420,11 @@ jobs:
420420
crate: cargo-edit
421421
bin: cargo-set-version
422422
- name: Update version if PR against main branch
423-
if: ${{ github.event_name == 'pull_request' && github.ref == 'refs/heads/main' }}
423+
if: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.ref == 'main' }}
424424
run: cargo set-version --offline --workspace 0.0.0-pr${{ github.event.pull_request.number }}
425425
- name: Update version if PR against non-main branch
426426
# For PRs to be merged against a release branch, use the version that has already been set in the calling script.
427-
if: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/main' }}
427+
if: ${{ github.event_name == 'pull_request' && startsWith(github.event.pull_request.base.ref, 'release-') }}
428428
env:
429429
PR_NUMBER: ${{ github.event.pull_request.number }}
430430
run: |

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,18 @@ All notable changes to this project will be documented in this file.
44

55
## [Unreleased]
66

7+
### Added
8+
9+
- Run a `containerdebug` process in the background of each OPA container to collect debugging information ([#666]).
10+
711
### Fixed
812

913
- BREAKING: Use distinct ServiceAccounts for the Stacklets, so that multiple Stacklets can be
1014
deployed in one namespace. Existing Stacklets will use the newly created ServiceAccounts after
1115
restart ([#656]).
1216

1317
[#656]: https://github.com/stackabletech/opa-operator/pull/656
18+
[#666]: https://github.com/stackabletech/opa-operator/pull/666
1419

1520
## [24.11.0] - 2024-11-18
1621

0 commit comments

Comments
 (0)