From 80746b0f58263cad9f6192e2156be8bfaed8806c Mon Sep 17 00:00:00 2001 From: dervoeti Date: Tue, 21 Jan 2025 14:04:13 +0100 Subject: [PATCH 1/2] Revert "docs: add hint regarding cluster domain to improve DNS performance" This reverts commit 37e194dd2d13d9b3f11dd34165b621a1c9fdee62. --- modules/guides/pages/kubernetes-cluster-domain.adoc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/modules/guides/pages/kubernetes-cluster-domain.adoc b/modules/guides/pages/kubernetes-cluster-domain.adoc index 9a7191f53..d10e9fda7 100644 --- a/modules/guides/pages/kubernetes-cluster-domain.adoc +++ b/modules/guides/pages/kubernetes-cluster-domain.adoc @@ -1,5 +1,5 @@ = Configuring the Kubernetes cluster domain -:description: Configure Stackable operators to use a different cluster domain other than 'cluster.local.'. +:description: Configure Stackable operators to use a different cluster domain other than 'cluster.local'. :dns-custom-nameservers: https://kubernetes.io/docs/tasks/administer-cluster/dns-custom-nameservers/ :dns-pod-service: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/ @@ -9,9 +9,7 @@ The cluster domain can be configured using an environment variable `KUBERNETES_C This environment variable can be configured via the helm values property `kubernetesClusterDomain` during the installation of the operators. ``` -helm install -operator stackable-stable/-operator --set kubernetesClusterDomain="my.domain." +helm install -operator stackable-stable/-operator --set kubernetesClusterDomain="my-cluster.local" ``` -Note that if you specify a custom cluster domain we recommend adding a trailing dot (`my.domain.` instead of `my.domain`) to reduce DNS requests (see https://github.com/stackabletech/issues/issues/656 for details). - -If the environment variable `KUBERNETES_CLUSTER_DOMAIN` (or the helm property `kubernetesClusterDomain`) are not set / overriden, the operator will default the cluster domain to `cluster.local.`. +If the environment variable `KUBERNETES_CLUSTER_DOMAIN` (or the helm property `kubernetesClusterDomain`) are not set / overriden, the operator will default the cluster domain to `cluster.local`. From 9527b94e584de5e753a28d4b86e6da496d59ba14 Mon Sep 17 00:00:00 2001 From: dervoeti Date: Tue, 21 Jan 2025 14:19:01 +0100 Subject: [PATCH 2/2] docs: add note on specifying custom cluster domain with trailing dot --- modules/guides/pages/kubernetes-cluster-domain.adoc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/guides/pages/kubernetes-cluster-domain.adoc b/modules/guides/pages/kubernetes-cluster-domain.adoc index d10e9fda7..e967fb390 100644 --- a/modules/guides/pages/kubernetes-cluster-domain.adoc +++ b/modules/guides/pages/kubernetes-cluster-domain.adoc @@ -9,7 +9,9 @@ The cluster domain can be configured using an environment variable `KUBERNETES_C This environment variable can be configured via the helm values property `kubernetesClusterDomain` during the installation of the operators. ``` -helm install -operator stackable-stable/-operator --set kubernetesClusterDomain="my-cluster.local" +helm install -operator stackable-stable/-operator --set kubernetesClusterDomain="my.domain" ``` +You can also specify a custom cluster domain with a trailing dot (`my.domain.` instead of `my.domain`) to reduce the number of DNS requests under certain conditions (see https://github.com/stackabletech/issues/issues/656 for details). Note however that support for this is still considered experimental. + If the environment variable `KUBERNETES_CLUSTER_DOMAIN` (or the helm property `kubernetesClusterDomain`) are not set / overriden, the operator will default the cluster domain to `cluster.local`.