Skip to content

Commit 675a70b

Browse files
committed
cleanup and better comment
1 parent 9dfe57e commit 675a70b

File tree

5 files changed

+9
-15
lines changed

5 files changed

+9
-15
lines changed

Cargo.lock

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.nix

Lines changed: 0 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ const_format = "0.2"
2020
fnv = "1.0"
2121
futures = { version = "0.3", features = ["compat"] }
2222
indoc = "2.0"
23-
lazy_static = "1.4"
2423
rstest = "0.25"
2524
semver = "1.0"
2625
serde = { version = "1.0", features = ["derive"] }

rust/operator-binary/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ clap.workspace = true
1717
const_format.workspace = true
1818
fnv.workspace = true
1919
futures.workspace = true
20-
lazy_static.workspace = true
2120
serde.workspace = true
2221
serde_json.workspace = true
2322
serde_yaml.workspace = true

rust/operator-binary/src/env_vars.rs

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,9 @@ const ADMIN_EMAIL: &str = "ADMIN_EMAIL";
5353

5454
const PYTHONPATH: &str = "PYTHONPATH";
5555

56-
/// TODO This key is only intended for use during experimental support and will
57-
/// be replaced with a secret at a later stage. The key should be consistent
58-
/// across replicas/roles for a given cluster, but should be cluster-specific
59-
/// and should be accessed from a secret to avoid cluster restarts being
60-
/// triggered by an operator restart.
56+
/// This key is only intended for use during experimental support and will
57+
/// be replaced with a secret at a later stage. See the issue covering
58+
/// this at <https://github.com/stackabletech/airflow-operator/issues/639>.
6159
const JWT_KEY: &str = "ThisKeyIsNotIntendedForProduction!";
6260

6361
#[derive(Snafu, Debug)]
@@ -465,9 +463,12 @@ fn add_version_specific_env_vars(
465463
);
466464
// As of 3.x a JWT key is required.
467465
// See https://airflow.apache.org/docs/apache-airflow/3.0.1/configurations-ref.html#jwt-secret
468-
// This must be random, but must also be consistent across api-services.
469-
// The key will be consistent for all clusters started by this
470-
// operator instance. TODO: Make this cluster specific.
466+
// This should be random, but must also be consistent across
467+
// api-services and replicas/roles for a given
468+
// cluster, but should also be cluster-specific.
469+
// See issue <https://github.com/stackabletech/airflow-operator/issues/639>:
470+
// later it will be accessed from a secret to avoid cluster restarts
471+
// being triggered by an operator restart.
471472
env.insert(
472473
"AIRFLOW__API_AUTH__JWT_SECRET".into(),
473474
EnvVar {

0 commit comments

Comments
 (0)