From bf5498b0c05e690fa11d0d304b71fad980ab7047 Mon Sep 17 00:00:00 2001 From: Jure Rotar Date: Mon, 16 Mar 2026 17:37:08 +0100 Subject: [PATCH] fix: fixed incorrect parameter types for Worker1Promiser's config-get --- README.md | 6 +----- src/index.d.ts | 26 ++++---------------------- 2 files changed, 5 insertions(+), 27 deletions(-) diff --git a/README.md b/README.md index 605d0bf..d58f54c 100644 --- a/README.md +++ b/README.md @@ -70,7 +70,7 @@ const initializeSQLite = async () => { log('Done initializing. Running demo...'); - const configResponse = await promiser('config-get'); + const configResponse = await promiser('config-get', {}); log('Running SQLite3 version', configResponse.result.version.libVersion); const openResponse = await promiser('open', { @@ -93,10 +93,6 @@ const initializeSQLite = async () => { await initializeSQLite(); ``` -For `config-get`, `promiser('config-get')` is the preferred form. For backward -compatibility, `promiser('config-get', undefined)` and -`promiser('config-get', {})` are also supported. - The `promiser` object above implements the [Worker1 API](https://sqlite.org/wasm/doc/trunk/api-worker1.md#worker1-methods). diff --git a/src/index.d.ts b/src/index.d.ts index 9aa24f4..4c78a69 100644 --- a/src/index.d.ts +++ b/src/index.d.ts @@ -1703,21 +1703,12 @@ type Worker1ConfigGetResult = { /** Map of Worker API #1 operation types to their argument types. */ type Worker1ArgsMap = { open: Worker1OpenArgs; - close: Worker1CloseArgs | undefined; + close: Worker1CloseArgs; exec: Worker1ExecArgs | string; - export: undefined; - 'config-get': undefined | Record; + export: Record; + 'config-get': Record; }; -type Worker1OptionalArgsOp = { - [K in keyof Worker1ArgsMap]: undefined extends Worker1ArgsMap[K] ? K : never; -}[keyof Worker1ArgsMap]; - -type Worker1RequiredArgsOp = Exclude< - keyof Worker1ArgsMap, - Worker1OptionalArgsOp ->; - /** Map of Worker API #1 operation types to their result types. */ type Worker1ResultMap = { open: Worker1OpenResult; @@ -1733,20 +1724,11 @@ export type Worker1Promiser = { * Sends a message to the worker and returns a Promise which resolves to the * response message. */ - ( + ( type: T, args: Worker1ArgsMap[T], ): Promise>; - /** - * Sends a message to the worker and returns a Promise which resolves to the - * response message. - */ - ( - type: T, - args?: Worker1ArgsMap[T], - ): Promise>; - /** * Sends a message to the worker and returns a Promise which resolves to the * response message.