feat: infer parameter types from function call return types in comparison expressions.

Author: noxymon

internal/compiler/resolve.go

@@ -142,6 +142,36 @@ func (comp *Compiler) resolveCatalogRefs(qc *QueryCatalog, rvs []*ast.RangeVar,
 			})
 
 		case *ast.A_Expr:
+			// If one side of the comparison is a direct FuncCall, use the
+			// function's return type for the parameter. This prevents the
+			// ColumnRef search below from descending into the function's
+			// arguments and incorrectly using a nested column's type
+			// (e.g. DATEDIFF(date_from, NOW()) >= ? should yield int, not date).
+			var funcCallSide *ast.FuncCall
+			if fc, ok := n.Lexpr.(*ast.FuncCall); ok {
+				funcCallSide = fc
+			} else if fc, ok := n.Rexpr.(*ast.FuncCall); ok {
+				funcCallSide = fc
+			}
+			if funcCallSide != nil {
+				fun, ferr := c.ResolveFuncCall(funcCallSide)
+				if ferr == nil && fun.ReturnType != nil && fun.ReturnType.Name != "any" {
+					defaultP := named.NewInferredParam(ref.name, true)
+					p, isNamed := params.FetchMerge(ref.ref.Number, defaultP)
+					a = append(a, Parameter{
+						Number: ref.ref.Number,
+						Column: &Column{
+							Name:         p.Name(),
+							DataType:     dataType(fun.ReturnType),
+							NotNull:      p.NotNull(),
+							IsNamedParam: isNamed,
+							IsSqlcSlice:  p.IsSqlcSlice(),
+						},
+					})
+					continue
+				}
+			}
+
 			// TODO: While this works for a wide range of simple expressions,
 			// more complicated expressions will cause this logic to fail.
 			list := astutils.Search(n.Lexpr, func(node ast.Node) bool {

internal/endtoend/testdata/mysql_datediff_type/mysql/db.go

@@ -0,0 +1,6 @@
+-- name: GetUpdateableWishlistItemIDs :many
+SELECT id
+FROM wishlist_item
+WHERE DATEDIFF(date_from, NOW()) >= sqlc.arg('min_days_to_date_from')
+  AND DATEDIFF(date_from, NOW()) <= sqlc.arg('max_days_to_date_from')
+  AND updated_at < sqlc.arg('updated_by');

internal/endtoend/testdata/mysql_datediff_type/mysql/models.go

@@ -0,0 +1,5 @@
+CREATE TABLE wishlist_item (
+    id         INT UNSIGNED NOT NULL AUTO_INCREMENT PRIMARY KEY,
+    date_from  DATE         NOT NULL,
+    updated_at TIMESTAMP    NULL DEFAULT NULL
+);

internal/endtoend/testdata/mysql_datediff_type/mysql/query.sql.go

@@ -0,0 +1,16 @@
+{
+    "version": "2",
+    "sql": [
+        {
+            "engine": "mysql",
+            "queries": "query.sql",
+            "schema": "schema.sql",
+            "gen": {
+                "go": {
+                    "package": "mysql_datediff_type",
+                    "out": "mysql"
+                }
+            }
+        }
+    ]
+}