Skip to content

Commit 172220c

Browse files
authored
Merge pull request #729 from splitrb/drop-support-older-rubies
Drop support older Rails, and add newer Rails support
2 parents 63bdd84 + ffd1d96 commit 172220c

File tree

8 files changed

+29
-56
lines changed

8 files changed

+29
-56
lines changed

.github/workflows/ci.yml

Lines changed: 20 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -6,43 +6,37 @@ jobs:
66
test:
77
strategy:
88
matrix:
9-
include:
10-
- gemfile: 6.0.gemfile
11-
ruby: 2.5
12-
13-
- gemfile: 6.0.gemfile
14-
ruby: 2.6
15-
16-
- gemfile: 6.0.gemfile
17-
ruby: 2.7
18-
19-
- gemfile: 6.0.gemfile
20-
ruby: '3.0'
21-
22-
- gemfile: 6.1.gemfile
23-
ruby: '3.0'
24-
25-
- gemfile: 7.0.gemfile
26-
ruby: '3.0'
27-
28-
- gemfile: 7.0.gemfile
29-
ruby: '3.1'
30-
31-
- gemfile: 7.0.gemfile
32-
ruby: '3.2'
33-
9+
ruby: ["3.4", "3.3", "3.2", "3.1", "3.0", "2.7"]
10+
rails: ["8.0", "7.2", "7.1", "6.1"]
11+
exclude:
12+
- rails: "6.1"
13+
ruby: "3.4"
14+
15+
- rails: "7.2"
16+
ruby: "2.7"
17+
- rails: "7.2"
18+
ruby: "3.0"
19+
20+
- rails: "8.0"
21+
ruby: "2.7"
22+
- rails: "8.0"
23+
ruby: "3.0"
24+
- rails: "8.0"
25+
ruby: "3.1"
3426
runs-on: ubuntu-latest
3527

3628
services:
3729
redis:
3830
image: redis
39-
ports: ['6379:6379']
31+
ports: ["6379:6379"]
4032
options: >-
4133
--health-cmd "redis-cli ping"
4234
--health-interval 10s
4335
--health-timeout 5s
4436
--health-retries 5
4537
38+
env:
39+
RAILS_VERSION: ${{ matrix.rails }}
4640
steps:
4741
- uses: actions/checkout@v4
4842

@@ -52,7 +46,6 @@ jobs:
5246

5347
- name: Install dependencies
5448
run: |
55-
bundle config set gemfile "${GITHUB_WORKSPACE}/gemfiles/${{ matrix.gemfile }}"
5649
bundle install --jobs 4 --retry 3
5750
5851
- name: Display Ruby version

Gemfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,6 @@ gemspec
66

77
gem "rubocop", require: false
88
gem "codeclimate-test-reporter"
9-
gem "rack", "< 3"
9+
gem "concurrent-ruby", "< 1.3.5"
10+
11+
gem "rails", "~> #{ENV.fetch('RAILS_VERSION', '8.0')}"

gemfiles/6.0.gemfile

Lines changed: 0 additions & 8 deletions
This file was deleted.

gemfiles/6.1.gemfile

Lines changed: 0 additions & 8 deletions
This file was deleted.

gemfiles/7.0.gemfile

Lines changed: 0 additions & 9 deletions
This file was deleted.

lib/split/dashboard.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ class Dashboard < Sinatra::Base
2929
if Object.const_defined?("Rails") && Rails.respond_to?(:env)
3030
@current_env = Rails.env.titlecase
3131
else
32-
@current_env = "Rack: #{Rack.version}"
32+
rack_version = Rack.respond_to?(:version) ? Rack.version : Rack.release
33+
@current_env = "Rack: #{rack_version}"
3334
end
3435
erb :index
3536
end

lib/split/persistence/cookie_adapter.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,9 @@ def default_options
4747
end
4848

4949
def set_cookie_via_rack(key, value)
50-
delete_cookie_header!(@response.header, key, value)
51-
Rack::Utils.set_cookie_header!(@response.header, key, value)
50+
headers = @response.respond_to?(:header) ? @response.header : @response.headers
51+
delete_cookie_header!(headers, key, value)
52+
Rack::Utils.set_cookie_header!(headers, key, value)
5253
end
5354

5455
# Use Rack::Utils#make_delete_cookie_header after Rack 2.0.0

split.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ Gem::Specification.new do |s|
3535
s.add_dependency "sinatra", ">= 1.2.6"
3636
s.add_dependency "rubystats", ">= 0.3.0"
3737
s.add_dependency "matrix"
38+
s.add_dependency "bigdecimal"
3839

3940
s.add_development_dependency "bundler", ">= 1.17"
4041
s.add_development_dependency "simplecov", "~> 0.15"

0 commit comments

Comments
 (0)