Skip to content

Commit 5bffc26

Browse files
authored
Merge pull request #114 from splitio/feature/oneSingleQueue
[SDKS-285]: Issue on DependencyMatcher
2 parents 54bcaf0 + ac6013c commit 5bffc26

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

splitio/matchers.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from six import string_types
1111
from splitio.transformers import AsDateHourMinuteTimestampTransformMixin, \
1212
AsNumberTransformMixin, AsDateTimestampTransformMixin, TransformMixin
13-
13+
from splitio.key import Key
1414

1515
DataType = Enum('DataType', 'DATETIME NUMBER')
1616

@@ -714,12 +714,16 @@ def __init__(self, dependency_matcher_data):
714714
def match(self, key, attributes=None, client=None):
715715
"""
716716
"""
717-
treatment = client.get_treatment(
718-
key,
717+
matching, bucketing = (key.matching_key, key.bucketing_key) \
718+
if isinstance(key, Key) else (key, None)
719+
treatment = client.evaluate_treatment(
719720
self._data.get('split'),
721+
matching,
722+
bucketing,
720723
attributes
721724
)
722-
return treatment in self._data.get('treatments', [])
725+
726+
return treatment['treatment'] in self._data.get('treatments', [])
723727

724728

725729
class BooleanMatcher(object):

splitio/tests/test_matchers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1058,9 +1058,9 @@ def test_matcher_construction(self):
10581058
'''
10591059
self.assertIsInstance(self._matcher, DependencyMatcher)
10601060

1061-
def test_matcher_client_is_created_and_get_treatment_called(self):
1061+
def test_matcher_client_is_created_and_evaluate_treatment_called(self):
10621062
self._matcher.match('abc', None, self._mock)
1063-
self._mock.get_treatment.assert_called_once_with('abc', 'someSplit', None)
1063+
self._mock.evaluate_treatment.assert_called_once_with('someSplit', 'abc', None, None)
10641064
self.assertTrue(True)
10651065

10661066

0 commit comments

Comments
 (0)