Merge pull request #100 from splitio/improvement/inputSanitization

[SDKS-29]: Python Input Validation

Author: mmelograno

splitio/clients.py

@@ -262,7 +262,7 @@ def track(self, key, traffic_type, event_type, value=None):
         traffic_type = input_validator.validate_traffic_type(traffic_type)
         value = input_validator.validate_value(value)
 
-        if key is None or event_type is None or traffic_type is None or value is None:
+        if key is None or event_type is None or traffic_type is None or value is False:
             return False
 
         event = Event(

splitio/input_validator.py

@@ -261,11 +261,11 @@ def validate_value(value):
     :return: value
     :rtype: number|None
     """
-    if _check_not_null(value, 'value', 'track') is False:
+    if value is None:
         return None
     if not isinstance(value, Number) or isinstance(value, bool):
         _LOGGER.error('track: value must be a number.')
-        return None
+        return False
     return value
 
 

splitio/tests/test_input_validator.py

@@ -298,10 +298,10 @@ def test_track_with_event_type_does_not_conform_reg_exp(self):
                                      "expression [a-zA-Z0-9][-_\\.a-zA-Z0-9]{0,62}.")
 
     def test_track_with_null_value(self):
-        self.assertEqual(False, self.client.track(
+        self.assertEqual(True, self.client.track(
             "some_key", "traffic_type", "event_type", None))
-        self.logger_error \
-            .assert_called_once_with("track: value cannot be None.")
+        self.logger_error.assert_not_called()
+        self.logger_warning.assert_not_called()
 
     def test_track_with_string_value(self):
         self.assertEqual(False, self.client.track(

splitio/version.py

@@ -1 +1 @@
-__version__ = '6.0.0'
+__version__ = '6.1.0'