Merge pull request #109 from engstrom/feature/localhost-file-parsing

Allow hypens in 'localhost mode' file values.

Author: mmelograno

splitio/brokers.py

@@ -381,7 +381,7 @@ def destroy(self):
 class LocalhostBroker(BaseBroker):
     _COMMENT_LINE_RE = re.compile('^#.*$')
     _DEFINITION_LINE_RE = re.compile(
-        '^(?<![^#])(?P<feature>[\w_]+)\s+(?P<treatment>[\w_]+)$'
+        '^(?<![^#])(?P<feature>[\w_-]+)\s+(?P<treatment>[\w_-]+)$'
     )
 
     class LocalhostEventStorage(object):

splitio/tests/test_clients.py

@@ -1183,10 +1183,10 @@ def test_skips_illegal_lines(self):
     def test_parses_definition_lines(self):
         """Test that _parse_split_file skips comment lines"""
         self.open_mock.return_value.__enter__.return_value.__iter__.return_value = [
-            'feature1 treatment1', 'feature2 treatment2']
+            'feature1 treatment1', 'feature-2 treatment-2']
         self.broker._parse_split_file(self.some_file_name)
         self.assertListEqual([mock.call('feature1', 'treatment1'),
-                              mock.call('feature2', 'treatment2')],
+                              mock.call('feature-2', 'treatment-2')],
                              self.all_keys_split_mock.call_args_list)
 
     def test_returns_dict_with_parsed_splits(self):