Skip to content

Commit 06407ef

Browse files
author
Matias Melograno
committed
fixed to use evaluate_treatment in dependency matcher
1 parent 66cc5b7 commit 06407ef

File tree

3 files changed

+18
-9
lines changed

3 files changed

+18
-9
lines changed

splitio/matchers.py

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from six import string_types
1111
from splitio.transformers import AsDateHourMinuteTimestampTransformMixin, \
1212
AsNumberTransformMixin, AsDateTimestampTransformMixin, TransformMixin
13-
13+
from splitio.key import Key
1414

1515
DataType = Enum('DataType', 'DATETIME NUMBER')
1616

@@ -714,12 +714,21 @@ def __init__(self, dependency_matcher_data):
714714
def match(self, key, attributes=None, client=None):
715715
"""
716716
"""
717-
treatment = client.evaluate_treatment(
718-
key,
719-
self._data.get('split'),
720-
attributes
721-
)
722-
return treatment in self._data.get('treatments', [])
717+
if isinstance(key, Key):
718+
treatment = client.evaluate_treatment(
719+
self._data.get('split'),
720+
key.matching_key,
721+
key.bucketing_key,
722+
attributes
723+
)
724+
else:
725+
treatment = client.evaluate_treatment(
726+
self._data.get('split'),
727+
key,
728+
None,
729+
attributes
730+
)
731+
return treatment['treatment'] in self._data.get('treatments', [])
723732

724733

725734
class BooleanMatcher(object):

splitio/tests/test_matchers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1060,7 +1060,7 @@ def test_matcher_construction(self):
10601060

10611061
def test_matcher_client_is_created_and_evaluate_treatment_called(self):
10621062
self._matcher.match('abc', None, self._mock)
1063-
self._mock.evaluate_treatment.assert_called_once_with('abc', 'someSplit', None)
1063+
self._mock.evaluate_treatment.assert_called_once_with('someSplit', 'abc', None, None)
10641064
self.assertTrue(True)
10651065

10661066

splitio/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '6.3.0-rc1'
1+
__version__ = '6.3.0-rc2'

0 commit comments

Comments
 (0)