Skip to content

Commit 9b4cb32

Browse files
committed
fix to cr endpoint
1 parent b4e717d commit 9b4cb32

1 file changed

Lines changed: 7 additions & 8 deletions

File tree

splitapiclient/microclients/change_request_microclient.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class ChangeRequestMicroClient:
1010
_endpoint = {
1111
'list_initial': {
1212
'method': 'GET',
13-
'url_template': 'changeRequests?limit=100',
13+
'url_template': 'changeRequests?limit=100&environmentId={environmentId}',
1414
'headers': [{
1515
'name': 'Authorization',
1616
'template': 'Bearer {value}',
@@ -21,7 +21,7 @@ class ChangeRequestMicroClient:
2121
},
2222
'list_next': {
2323
'method': 'GET',
24-
'url_template': 'changeRequests?limit=100&after={after}',
24+
'url_template': 'changeRequests?limit=100&environmentId={environmentId}&after={after}',
2525
'headers': [{
2626
'name': 'Authorization',
2727
'template': 'Bearer {value}',
@@ -60,7 +60,7 @@ def __init__(self, http_client):
6060
'''
6161
self._http_client = http_client
6262

63-
def list(self):
63+
def list(self, environment_id):
6464
'''
6565
Returns a list of change request objects.
6666
@@ -72,7 +72,8 @@ def list(self):
7272
while True:
7373
if afterMarker==0:
7474
response = self._http_client.make_request(
75-
self._endpoint['list_initial']
75+
self._endpoint['list_initial'],
76+
environmentId = environment_id
7677
)
7778
else:
7879
response = self._http_client.make_request(
@@ -86,7 +87,7 @@ def list(self):
8687
else:
8788
afterMarker = response['nextMarker']
8889
continue
89-
return [ChangeRequest(item, self._http_client) for item in final_list]
90+
return [ChangeRequest(item, self._http_client) for item in final_list]
9091

9192
def find(self, split_name=None, segment_name=None, environment_id=None):
9293
'''
@@ -96,12 +97,10 @@ def find(self, split_name=None, segment_name=None, environment_id=None):
9697
:rtype: list(ChangeRequest)
9798
'''
9899
final_list = []
99-
for item in self.list():
100+
for item in self.list(environment_id):
100101
if item._split != None:
101102
if item._split['name'] == split_name:
102103
final_list.append(item)
103-
if item._split['environment']['id'] == environment_id:
104-
final_list.append(item)
105104
if item._segment != None:
106105
if item._segment['name'] == segment_name:
107106
final_list.append(item)

0 commit comments

Comments
 (0)