set production url as deafult

Author: mredolatti

splitapiclient/main/sync_apiclient.py

@@ -14,6 +14,8 @@ class SyncApiClient(BaseApiClient):
     Synchronous Split API client
     '''
 
+    BASE_PROD_URL = 'https://api.split.io/internal/api/v1'
+
     def __init__(self, config):
         '''
         Class constructor.
@@ -23,16 +25,19 @@ def __init__(self, config):
                 - 'base_url': Base url where the API is hosted
                 - 'apikey': APIKey used to authenticate the user.
         '''
-        if 'base_url' in config and 'apikey' in config:
+        if 'base_url' in config:
             self._base_url = config['base_url']
-            self._apikey = config['apikey']
         else:
-            missing = [i for i in ['base_url', 'apikey'] if i not in config]
+            self._base_url = self.BASE_PROD_URL
+
+        missing = [i for i in ['apikey'] if i not in config]
+        if missing:
             raise InsufficientConfigArgumentsException(
                 'The following keys must be present in the config dict: %s'
                 % ','.join(missing)
             )
 
+        self._apikey = config['apikey']
         http_client = SyncHttpClient(self._base_url, self._apikey)
 
         self._traffic_type_client = TrafficTypeMicroClient(http_client)

splitapiclient/tests/main/test_splitapiclient.py

@@ -0,0 +1,27 @@
+from __future__ import absolute_import, division, print_function, \
+    unicode_literals
+
+import pytest
+from splitapiclient.main.sync_apiclient import SyncApiClient
+from splitapiclient.util.exceptions import InsufficientConfigArgumentsException
+
+class TestSyncApiClient:
+    '''
+    '''
+
+    def test_constructor(self, mocker):
+        '''
+        '''
+        # Should have PROD url by default
+        c1 = SyncApiClient({'apikey': '123'})
+        assert c1._base_url == SyncApiClient.BASE_PROD_URL
+        assert c1._apikey == '123'
+
+        # Should fail if no apikey propvided
+        with pytest.raises(InsufficientConfigArgumentsException):
+            c2 = SyncApiClient({})
+
+        # Should override url if passed
+        c3 = SyncApiClient({'base_url': 'http://test', 'apikey': '123'})
+        assert c3._base_url == 'http://test'
+        assert c3._apikey == '123'