Skip to content

Commit 33490b9

Browse files
authored
Merge pull request #3 from kleinjoshuaa/master
Added optional environmentId and Status parameters to changeRequests list endpoint Added optional Status to to changeRequests find endpoint
2 parents b4e717d + 982f59b commit 33490b9

1 file changed

Lines changed: 16 additions & 8 deletions

File tree

splitapiclient/microclients/change_request_microclient.py

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class ChangeRequestMicroClient:
1818
}],
1919
'query_string': [],
2020
'response': True,
21-
},
21+
},
2222
'list_next': {
2323
'method': 'GET',
2424
'url_template': 'changeRequests?limit=100&after={after}',
@@ -60,7 +60,7 @@ def __init__(self, http_client):
6060
'''
6161
self._http_client = http_client
6262

63-
def list(self):
63+
def list(self, environment_id, status):
6464
'''
6565
Returns a list of change request objects.
6666
@@ -69,14 +69,24 @@ def list(self):
6969
'''
7070
final_list = []
7171
afterMarker = 0
72+
if(environment_id!=None):
73+
self._endpoint['list_next']['url_template'] = self._endpoint['list_next']['url_template'] + "&environmentId={environmentId}"
74+
self._endpoint['list_initial']['url_template'] = self._endpoint['list_initial']['url_template'] + "&environmentId={environmentId}"
75+
if(status!=None):
76+
self._endpoint['list_next']['url_template'] = self._endpoint['list_next']['url_template'] + "&status={status}"
77+
self._endpoint['list_initial']['url_template'] = self._endpoint['list_initial']['url_template'] + "&status={status}"
7278
while True:
7379
if afterMarker==0:
7480
response = self._http_client.make_request(
75-
self._endpoint['list_initial']
81+
self._endpoint['list_initial'],
82+
status=status,
83+
environmentId=environment_id
7684
)
7785
else:
7886
response = self._http_client.make_request(
7987
self._endpoint['list_next'],
88+
status=status,
89+
environmentId=environment_id,
8090
after = afterMarker
8191
)
8292
for item in response['data']:
@@ -86,22 +96,20 @@ def list(self):
8696
else:
8797
afterMarker = response['nextMarker']
8898
continue
89-
return [ChangeRequest(item, self._http_client) for item in final_list]
99+
return [ChangeRequest(item, self._http_client) for item in final_list]
90100

91-
def find(self, split_name=None, segment_name=None, environment_id=None):
101+
def find(self, split_name=None, segment_name=None, environment_id=None, status=None):
92102
'''
93103
Find Change requests for optional environment, split name or segment name objects.
94104
95105
:returns: list of change request objects
96106
:rtype: list(ChangeRequest)
97107
'''
98108
final_list = []
99-
for item in self.list():
109+
for item in self.list(environment_id, status):
100110
if item._split != None:
101111
if item._split['name'] == split_name:
102112
final_list.append(item)
103-
if item._split['environment']['id'] == environment_id:
104-
final_list.append(item)
105113
if item._segment != None:
106114
if item._segment['name'] == segment_name:
107115
final_list.append(item)

0 commit comments

Comments
 (0)