1- Added support for owners array in split get and create endpoints.

2- Added support for get split api

Author: chillaq

splitapiclient/microclients/split_microclient.py

@@ -43,6 +43,17 @@ class SplitMicroClient:
             'query_string': [],
             'response': True,
         },
+        'get': {
+            'method': 'GET',
+            'url_template': ('splits/ws/{workspaceId}/{splitName}'),
+            'headers': [{
+                'name': 'Authorization',
+                'template': 'Bearer {value}',
+                'required': True,
+            }],
+            'query_string': [],
+            'response': True,
+        },
         'all_items': {
             'method': 'GET',
             'url_template': 'splits/ws/{workspaceId}?limit=20&offset={offset}{tags}',
@@ -139,6 +150,24 @@ def find(self, split_name, workspace_id, tags):
         LOGGER.error("Split Name does not exist")
         return None
 
+    def get(self, split_name, workspace_id):
+        '''
+        get a split details
+
+        :param split_name: split name
+        :param workspace_id: workspace id
+
+        :returns: split object
+        :rtype: Split
+        '''
+        response = self._http_client.make_request(
+            self._endpoint['get'],
+            workspaceId = workspace_id,
+            splitName = split_name
+        )
+        response['workspaceId'] = workspace_id
+        return Split(response, workspace_id, self._http_client)
+
     def add(self, split, traffic_type_name, workspace_id):
         '''
         add a split

splitapiclient/resources/split.py

@@ -21,7 +21,8 @@ class Split(BaseResource):
             'name': 'string'
         },
         'rolloutStatusTimestamp': 'number',
-        'tags': [{'name': 'string'}]
+        'tags': [{'name': 'string'}],
+        'owners': [{'id':'string','type':'string'}]
     }
 
     def __init__(self, data=None, workspace_id=None, client=None):
@@ -39,6 +40,7 @@ def __init__(self, data=None, workspace_id=None, client=None):
         self._id = data.get('id') if 'id' in data else None
         self._rolloutStatus = data.get('rolloutStatus') if 'rolloutStatus' in data else {}
         self._rolloutStatusTimestamp = data.get('rolloutStatusTimestamp') if 'rolloutStatusTimestamp' in data else 0
+        self._owners = data.get('owners') if 'owners' in data else []
 
     @property
     def name(self):

…/microclients/splitt_microclient_test.py …s/microclients/split_microclient_test.pysplitapiclient/tests/microclients/splitt_microclient_test.py renamed to splitapiclient/tests/microclients/split_microclient_test.py splitapiclient/tests/microclients/splitt_microclient_test.py renamed to splitapiclient/tests/microclients/split_microclient_test.py

@@ -20,15 +20,17 @@ def test_list(self, mocker):
                 'id': None,
                 'rolloutStatus': None,
                 'rolloutStatusTimestamp': None,
-                'tags': None
+                'tags': None,
+                'owners': None
             }, {
                 'name': 'sp2',
                 'description': 'desc',
                 'creationTime' : None,
                 'id': None,
                 'rolloutStatus': None,
                 'rolloutStatusTimestamp': None,
-                'tags': None
+                'tags': None,
+                'owners': None
             }],
             'offset': 1,
             'totalCount': 2,
@@ -55,6 +57,7 @@ def test_list(self, mocker):
             'rolloutStatus': None,
             'rolloutStatusTimestamp': None,
             'tags': None,
+            'owners': None,
             'id': None
         }, {
             'name': 'sp2',
@@ -65,8 +68,47 @@ def test_list(self, mocker):
             'rolloutStatus': None,
             'rolloutStatusTimestamp': None,
             'tags': None,
+            'owners': None,
             'id': None
         }]
 
         assert result[0].to_dict() == data[0]
         assert result[1].to_dict() == data[1]
+
+    def test_get(self, mocker):
+        '''
+        '''
+        mocker.patch('splitapiclient.http_clients.sync_client.SyncHttpClient.make_request')
+        sc = SyncHttpClient('abc', 'abc')
+        emc = SplitMicroClient(sc)
+        data = {
+            'name': 'sp1',
+            'description': 'desc',
+            'creationTime' : None,
+            'id': None,
+            'rolloutStatus': None,
+            'rolloutStatusTimestamp': None,
+            'tags': None,
+            'owners': None
+        }
+
+        SyncHttpClient.make_request.return_value = data
+        result = emc.get('sp1', 'ws_id')
+        SyncHttpClient.make_request.assert_called_once_with(
+            SplitMicroClient._endpoint['get'],
+            workspaceId = 'ws_id',
+            splitName = 'sp1'
+        )
+        data = {
+            'name': 'sp1',
+            'description': 'desc',
+            'trafficType' : None,
+            'creationTime' : None,
+            'id': 'sp1',
+            'rolloutStatus': None,
+            'rolloutStatusTimestamp': None,
+            'tags': None,
+            'owners': None,
+            'id': None
+        }
+        assert result.to_dict() == data

splitapiclient/tests/resources/test_split.py

@@ -131,7 +131,8 @@ def test_update_description(self, mocker):
             'id': 'split1',
             'rolloutStatus': None,
             'rolloutStatusTimestamp': None,
-            'tags': None
+            'tags': None,
+            'owners': None
         }
 
         http_client_mock = mocker.Mock(spec=BaseHttpClient)