workflow: remove header file, enable detekt (#98)

* refactor: remove license header file

fixes sourceplusplus/sourceplusplus#559

* workflow: re-enable detekt

* workflow: check cli

* Update detekt.yml

Author: BFergerson

.github/workflows/build.yml

@@ -226,7 +226,8 @@ jobs:
       - name: "[CLI] Reset"
         run: ./build/graal/spp-cli -v admin reset
 
-      - run: ./gradlew test -Dtest.profile=integration
+      - name: Check CLI
+        run: ./gradlew check -Dtest.profile=integration
 
       - name: Compress CLI
         uses: svenstaro/upx-action@v2

LICENSE-HEADER.txt

@@ -17,6 +17,7 @@ plugins {
     id("com.github.johnrengelman.shadow")
     id("com.apollographql.apollo3")
     id("com.avast.gradle.docker-compose")
+    id("io.gitlab.arturbosch.detekt")
     kotlin("jvm")
 }
 
@@ -64,6 +65,8 @@ dependencies {
     implementation("org.jetbrains.kotlinx:kotlinx-datetime:0.4.0")
 
     testImplementation("org.junit.jupiter:junit-jupiter-engine:$jupiterVersion")
+
+    detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.21.0")
 }
 
 configure<app.cash.licensee.LicenseeExtension> {
@@ -170,6 +173,45 @@ apollo {
 spotless {
     kotlin {
         targetExclude("**/generated/**")
-        licenseHeaderFile(file("LICENSE-HEADER.txt"))
+
+        val startYear = 2022
+        val currentYear = Calendar.getInstance().get(Calendar.YEAR)
+        val copyrightYears = if (startYear == currentYear) {
+            "$startYear"
+        } else {
+            "$startYear-$currentYear"
+        }
+
+        val jetbrainsProject = findProject(":protocol") ?: rootProject
+        val licenseHeader = Regex("( . Copyright [\\S\\s]+)")
+            .find(File(jetbrainsProject.projectDir, "LICENSE").readText())!!
+            .value.lines().joinToString("\n") {
+                if (it.trim().isEmpty()) {
+                    " *"
+                } else {
+                    " * " + it.trim()
+                }
+            }
+        val formattedLicenseHeader = buildString {
+            append("/*\n")
+            append(
+                licenseHeader.replace(
+                    "Copyright [yyyy] [name of copyright owner]",
+                    "Source++, the open-source live coding platform.\n" +
+                            " * Copyright (C) $copyrightYears CodeBrig, Inc."
+                ).replace(
+                    "http://www.apache.org/licenses/LICENSE-2.0",
+                    "    http://www.apache.org/licenses/LICENSE-2.0"
+                )
+            )
+            append("/")
+        }
+        licenseHeader(formattedLicenseHeader)
     }
 }
+
+detekt {
+    parallel = true
+    buildUponDefaultConfig = true
+    config.setFrom(arrayOf(File(project.rootDir, "detekt.yml")))
+}

build.gradle.kts

@@ -2,15 +2,19 @@
 # https://github.com/detekt/detekt/blob/master/detekt-core/src/main/resources/default-detekt-config.yml
 
 build:
-  maxIssues: 18 #todo: zero out
+  maxIssues: 21 #todo: zero out
 
 formatting:
   Indentation:
-    active: true
+    active: false
   CommentSpacing:
     active: false
   NoWildcardImports:
     active: false
+  ChainWrapping:
+    active: false
+  Wrapping:
+    active: false
 
 style:
   MagicNumber:
@@ -29,11 +33,9 @@ exceptions:
     active: false
   TooGenericExceptionThrown:
     excludes: ['**/test/**']
-  PrintStackTrace:
-    excludes: ['**/SourcePlatform.kt', '**/ServiceProvider.kt']
 
 complexity:
   LongParameterList:
     functionThreshold: 8
   LongMethod:
-    excludes: ['**/test/**']
+    excludes: ['**/test/**']