clear any auth from the endpoint url at program load

Author: peterguy

cmd/src/code_intel_upload.go

@@ -191,7 +191,6 @@ func makeCodeIntelUploadURL(uploadID int) string {
 	u := *cfg.endpointURL
 	graphqlID := base64.URLEncoding.EncodeToString(fmt.Appendf(nil, `SCIPUpload:%d`, uploadID))
 	u.Path = codeintelUploadFlags.repo + "/-/code-intelligence/uploads/" + graphqlID
-	u.User = nil
 	return u.String()
 }
 

cmd/src/main.go

@@ -119,6 +119,9 @@ func parseEndpoint(endpoint string) (*url.URL, error) {
 	if u.Host == "" {
 		return nil, errors.Newf("empty host")
 	}
+	// auth in the URL is not used, and could be explosed in log output.
+	// Explicitly clear it in case it's accidentally set in SRC_ENDPOINT or the config file.
+	u.User = nil
 	return u, nil
 }